Your message dated Thu, 29 Dec 2022 18:42:14 +0000 with message-id <e1paxr4-0069re...@fasolo.debian.org> and subject line Bug#738279: fixed in gramophone2 0.8.13a-3.2 has caused the Debian Bug report #738279, regarding gramophone2: Please support building with --as-needed to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 738279: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=738279 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
--- Begin Message ---Package: gramophone2 Version: 0.8.13a-3 Severity: wishlist Tags: patch User: ubuntu-de...@lists.ubuntu.com Usertags: origin-ubuntu trusty ubuntu-patch -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 *** /tmp/tmpaMKyaB/bug_body In Ubuntu, the attached patch was applied to achieve the following: * Update debian/patches/makefile.diff to put "-lm" into LDLIBS instead of CFLAGS. The position of this parameter matters because Ubuntu uses --as- needed as a default compiler flag and libs need to come after objects on the command line. (LP: #1277954) The included Makefile for unix has some problems: It adds -lm to the CFLAGS. -lm is a linker option and as such has no place in CFLAGS (which are used for compiler flags). Due to this, -lm appears on the command line way before any object files. This leads to it being discarded when the linker flag --as-needed is set. An example failure can be observed under Ubuntu: /«PKGBUILDDIR»/grammyVM.c:1498: undefined reference to `log10' To solve this I did: a) Add -lm to LDLIBS b) Added LDLIBS at the end of the command line Thanks for considering the patch. - -- System Information: Debian Release: jessie/sid APT prefers trusty APT policy: (700, 'trusty') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 3.13.0-8-generic (SMP w/4 CPU cores) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJS9pw/AAoJEGHzRCZ03mYkCEkQAMu51r1m1lfOdMFkZNdNlAH3 4xUE0O2XRzD1CxkJcNQv+9HGU/W5jvrND2cNfDUwDRGR2Z84tgTx3l8auhVS27p1 H4V9bxJUTGDjB1tpQa/t2fwcQ1L6goyJ6H33GsUJF8dYszq/AjucBsfpf3pUWvpD MjXR50f4rb210hU610TcjqCw3q1f3K+PXFPdrZcqp6sR0p36lM0KErusBIWnaRQh XhmHsC1R2tH9AVcSOCfLcBLdcaeJ0CZR3GsbBZ9MhZT7mhMwtGZ5MC47iq7dxjqi Qw9Hor1y5YurNSniqvhKwMVRkdMyttoZEqUMbFQLU+Nxe5tmDJFemlLNbc5E/EGx 77EOBc64mwEptenzJQ5G1JlGk5G3SHB9lSiu6iINHUGZgdKv9fq1qfVt9+krWjU8 sPsPlfG/ycIRWgK+M7Sb1ZvfLSm37jIOk9H/xIXISgFg3WhshQz17plU4N6hoC7r GhHb+DHupNwGI/CVHWYm6g+zqt6MFlIT7JsqeI0occt8qTDg5mJr82iNWNyxHrbh oHKX5MlAN4fBDL5Pn/g12Sn7/oE4jKPA9G9AsIYhTmSFQMY/CsJbai91JciyzGe/ jpgAc+9+lCGQETl3ZG3nGBcWtYS5gmryo8FiSS5pU1L01d5q6jESQUAieMA032Lo 7lxtriPwiMK3+k1rIMpX =C5zb -----END PGP SIGNATURE-----diff -Nru gramophone2-0.8.13a/debian/changelog gramophone2-0.8.13a/debian/changelog diff -Nru gramophone2-0.8.13a/debian/patches/Makefile.diff gramophone2-0.8.13a/debian/patches/Makefile.diff --- gramophone2-0.8.13a/debian/patches/Makefile.diff 2014-01-28 11:40:11.000000000 +0100 +++ gramophone2-0.8.13a/debian/patches/Makefile.diff 2014-02-08 21:56:13.000000000 +0100 @@ -1,6 +1,26 @@ ---- a/Makefile -+++ b/Makefile -@@ -6,7 +6,7 @@ +Description: The included Makefile for unix has some problems: + It adds -lm to the CFLAGS. -lm is a linker option and as such + has no place in CFLAGS (which are used for compiler flags). + Due to this, -lm appears on the command line way before any + object files. This leads to it being discarded when the linker + flag --as-needed is set. An example failure can be observed under + Ubuntu: /«PKGBUILDDIR»/grammyVM.c:1498: undefined reference to `log10' +Forwarded: yes, https://sourceforge.net/p/gramophone2/bugs/3/attachment/Makefile +Bug: https://sourceforge.net/p/gramophone2/bugs/3/ +Bug-Ubuntu: https://bugs.launchpad.net/bugs/1277954 + +Index: gramophone2-0.8.13a/Makefile +=================================================================== +--- gramophone2-0.8.13a.orig/Makefile 2014-02-08 21:45:36.087812116 +0100 ++++ gramophone2-0.8.13a/Makefile 2014-02-08 21:46:00.875811707 +0100 +@@ -1,15 +1,16 @@ + CC=gcc + #CFLAGS+=-O2 + #Decomment this line if you use Linux: +-CFLAGS+=-O2 -lm ++CFLAGS+=-O2 ++LDLIBS+=-lm + DESTDIR=/usr/local default: GRAMophone.tab.c @@ -8,4 +28,8 @@ + $(CC) $(CPPFLAGS) $(CFLAGS) $(LDFLAGS) -o gramophone2 GRAMophone.c\ grammyVM.c init.c midicode.c\ midifile.c expcode.c debug.c errors.c\ - hash.c GRAMophone.tab.c +- hash.c GRAMophone.tab.c ++ hash.c GRAMophone.tab.c $(LDLIBS) + + GRAMophone.tab.c: lex.yy.c + bison -d GRAMophone.y
--- End Message ---
--- Begin Message ---Source: gramophone2 Source-Version: 0.8.13a-3.2 Done: Ying-Chun Liu (PaulLiu) <paul...@debian.org> We believe that the bug you reported is fixed in the latest version of gramophone2, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 738...@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Ying-Chun Liu (PaulLiu) <paul...@debian.org> (supplier of updated gramophone2 package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmas...@ftp-master.debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Format: 1.8 Date: Tue, 13 Dec 2022 05:48:33 +0800 Source: gramophone2 Architecture: source Version: 0.8.13a-3.2 Distribution: unstable Urgency: low Maintainer: Francesco Namuri <fra...@debian.org> Changed-By: Ying-Chun Liu (PaulLiu) <paul...@debian.org> Closes: 738279 760662 965567 966862 Changes: gramophone2 (0.8.13a-3.2) unstable; urgency=low . [ Ying-Chun Liu (PaulLiu) <paul...@debian.org> ] * Non-maintainer upload. * Bump debhelper compat to 10. (Closes: #965567) [ Lukas Märdian <sl...@ubuntu.com> ] * Fix FTBFS by gcc-10 (Closes: #966862) [ Nicolas Sévelin-Radiguet <nic...@free.fr> ] * Fix FTBFS by clang (Closes: #760662) [ Andreas Moog <am...@ubuntu.com> ] * Include patches from Ubuntu (Closes: #738279) Checksums-Sha1: 56379322077c506b3996ab572ebb355232dba99c 1836 gramophone2_0.8.13a-3.2.dsc bfac27418390cb84f9a8be6b2d1c4e9b696d8b33 3820 gramophone2_0.8.13a-3.2.debian.tar.xz a4e0e6097314ba7d092f394f539abe8833699443 6911 gramophone2_0.8.13a-3.2_source.buildinfo Checksums-Sha256: f545401d23185418f9f8ddbee007b965b6e0eccc5ac700343b8357150479d39d 1836 gramophone2_0.8.13a-3.2.dsc 7e76cc19fd16f56fbf115e6aeb911b5ab74007c3b1ab4ea90a71ec452df92df3 3820 gramophone2_0.8.13a-3.2.debian.tar.xz 5726dbba86cc27a19c53a6a161a65dd56e54804351ea5b356a333a1e07b60f45 6911 gramophone2_0.8.13a-3.2_source.buildinfo Files: 30351ae6e9676bbee4ec1211e8e9f9f5 1836 sound optional gramophone2_0.8.13a-3.2.dsc ce531e8a86ae7cfb0cdefe2ac2d8b0b3 3820 sound optional gramophone2_0.8.13a-3.2.debian.tar.xz c4d27f658b48b6f533a1e055dfa5675c 6911 sound optional gramophone2_0.8.13a-3.2_source.buildinfo -----BEGIN PGP SIGNATURE----- iQJHBAEBCgAxFiEEo2h49GQQhoFgDLZIRBc/oT0FiIgFAmOgocATHHBhdWxsaXVA ZGViaWFuLm9yZwAKCRBEFz+hPQWIiKSfD/9KUkgta2J4LBL0OvGuHgBFKdWshEDH jlAYy6BNwBNNTQbRBfUSXjraVCHKuC5Np+eaOV0xbVI4OE9HFzA4KCarsOQdviiy Skd8FvItqcM3EoZMLbPQnTOfeeAP8jKtBLE99rQBhaLbzkQYwkmlDIlgZL5ZKWVu 1TrPwfgPHa+El7iBueYQCoX32Er8Ke7YAteXR2MBd5+B69yJRl7XchF+7SZV6UOJ eq86TFnpDFc4usUh//+4hQNDFKVIQHYczIDvGQt+bGyrh+eYtintSIPRJwsYbe9k SSvsce4apeLknHv2xEJ+wYIViBBzVi6NtbWx504jwiqXPHv8pj3V924qFLeQtfAL craiIK28QVn/A2Sr8Xdia/Hq4DGEvmd3BwVcEhjOPy1VuVP5i/H7PAufRDIWC2oO DMmq/i/sfZPZOYuW6gtZUr8NVPBjJraLEWmQyovEyTPkHLzmyx3Ktl8zmf/w9xXO O0ckQ9jyyMTOWhdro5ncIZVSy94peSlaxpbuVDYfRiIGi8QeoohMc+LUVco1XwYB xr5qiA3kqSLGICb9grZ4d2OJQaThkiCmKPF3JJge50LbtOfQgmNJNtH9C1intVw5 A/cDcrrp7yRFThzd83GtdxsU/tZ0cx68auDMoK3AsyNKl+BT/cxf5N+DxIL7ksQX GaeW66xxs6Oz1A== =HG0A -----END PGP SIGNATURE-----
--- End Message ---
