Your message dated Fri, 02 Dec 2022 17:06:00 +0000
with message-id <e1p19u8-0097ev...@fasolo.debian.org>
and subject line Bug#1016584: fixed in node-canvas-confetti 1.5.1+~1.4.3-2
has caused the Debian Bug report #1016584,
regarding node-canvas-confetti: please make the build reproducible
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
1016584: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1016584
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: node-canvas-confetti
Version: 1.5.1+~1.4.3-1
Severity: wishlist
Tags: patch
User: reproducible-bui...@lists.alioth.debian.org
Usertags: timestamps
X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org
Hi,
Whilst working on the Reproducible Builds effort [0] we noticed that
node-canvas-confetti could not be built reproducibly.
This is because embedded the build time into the file. Whilst I could
have patched this to use SOURCE_DATE_EPOCH, it seems more sensible to
simply drop the timestamp; it's in a comment anyway and "built on" using
the value of SOURCE_DATE_EPOCH may even be misleading.
[0] https://reproducible-builds.org/
Regards,
--
,''`.
: :' : Chris Lamb
`. `'` la...@debian.org / chris-lamb.co.uk
`-
--- a/debian/patches/reproducible-build.patch 1969-12-31 16:00:00.000000000
-0800
--- b/debian/patches/reproducible-build.patch 2022-08-03 08:00:30.310187371
-0700
@@ -0,0 +1,24 @@
+Description: Make the build reproducible
+Author: Chris Lamb <la...@debian.org>
+Last-Update: 2022-08-03
+
+--- node-canvas-confetti-1.5.1+~1.4.3.orig/build/build.js
++++ node-canvas-confetti-1.5.1+~1.4.3/build/build.js
+@@ -26,7 +26,7 @@ function writeFile(file, content) {
+ }
+
+ function buildCommonJs(content) {
+- return `// ${name} v${version} built on ${buildDate}
++ return `// ${name} v${version}
+ !(function (window, module) {
+ // source content
+ ${content}
+@@ -38,7 +38,7 @@ ${content}
+ }
+
+ function buildModule(content) {
+- return `// ${name} v${version} built on ${buildDate}
++ return `// ${name} v${version}
+ var module = {};
+
+ // source content
--- a/debian/patches/series 2022-08-03 07:57:12.233950517 -0700
--- b/debian/patches/series 2022-08-03 08:00:27.686184206 -0700
@@ -1 +1,2 @@
replace-old-ava-by-jest.patch
+reproducible-build.patch
--- End Message ---
--- Begin Message ---
Source: node-canvas-confetti
Source-Version: 1.5.1+~1.4.3-2
Done: Jelmer Vernooij <jel...@debian.org>
We believe that the bug you reported is fixed in the latest version of
node-canvas-confetti, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 1016...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Jelmer Vernooij <jel...@debian.org> (supplier of updated node-canvas-confetti
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Fri, 02 Dec 2022 16:45:47 +0000
Source: node-canvas-confetti
Architecture: source
Version: 1.5.1+~1.4.3-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Javascript Maintainers
<pkg-javascript-de...@lists.alioth.debian.org>
Changed-By: Jelmer Vernooij <jel...@debian.org>
Closes: 1016584
Changes:
node-canvas-confetti (1.5.1+~1.4.3-2) unstable; urgency=medium
.
* Team upload
.
[ Chris Lamb ]
* Make the build reproducible (Closes: #1016584)
.
[ Yadd ]
* Declare compliance with policy 4.6.1
.
[ Debian Janitor ]
* Apply multi-arch hints. + node-canvas-confetti: Add Multi-Arch: foreign.
Checksums-Sha1:
9a62366e063db841eac7d752e95c7319da393e8c 2562
node-canvas-confetti_1.5.1+~1.4.3-2.dsc
2ca0b185559e77116bfbb491e1e402915a1c8e39 4412
node-canvas-confetti_1.5.1+~1.4.3-2.debian.tar.xz
4501f0f6ec9729a9279a0e61904f2128cc3082df 20611
node-canvas-confetti_1.5.1+~1.4.3-2_amd64.buildinfo
Checksums-Sha256:
a4794ae52bdedbff8d706757cbe7bcbbe98763acc8ff7a2983f3434f174734f3 2562
node-canvas-confetti_1.5.1+~1.4.3-2.dsc
0364b5cc6d769f48dc7c49a079e7b75a7c85fc5bf538cf242d186df39fb2180a 4412
node-canvas-confetti_1.5.1+~1.4.3-2.debian.tar.xz
9d198d522c9299e5139c39860f5a054cda76d24a8c39c049ae7cccc105df31dd 20611
node-canvas-confetti_1.5.1+~1.4.3-2_amd64.buildinfo
Files:
7da1b6729efb337ed9ae2a045cb8dbc1 2562 javascript optional
node-canvas-confetti_1.5.1+~1.4.3-2.dsc
7d3e59d86d731fe63b56b504e726931e 4412 javascript optional
node-canvas-confetti_1.5.1+~1.4.3-2.debian.tar.xz
932c1d5ee73de35f707a4f616749e1c3 20611 javascript optional
node-canvas-confetti_1.5.1+~1.4.3-2_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEsjhixBXWVlpOhsvXV5wWDUyeI+gFAmOKLAgACgkQV5wWDUye
I+iOaRAAz3QDA6CVj+0jy66WIvSEZIyEP9McUhXWSPcyFaMBjFvEJXFjYcpFo6dH
TnStqUQ6J0fEjW/DbYDmPdaoLHiNxU4XRmI6DQVtRDF0Zqcg2Dn4a/9X6JqWVssT
845+GPBlExocam+6hUJunJMqjcmFG5m878Q33I1XD9mc0QuHjBI8PnRyljDCZSaZ
5iVUqnKC94GoApfczpae/bCSoJkMIwyi0UQEGTUbP45bezTKKK2hlyxMrNPjAw44
IW1J5NGxRsHT+sedJNISyPmC6tknnEPuYASooLE/xiauheo9Lz8sGnqvgkc0elvH
ArtUvEdLLOD9wr8YEv2pmNyaKNidF77aQoE/UYf6+/b+0/2+N+YTvErZucAYS3gX
WU90UikZjZVE1hHr+t7gPkoqkqOJ3BQkls+ZP9UEB/VD7RNKqYWFN3fDm75wR7Bi
/0lYkv90RgNNKqYpON9m44GqAuYKU2BUzrgONwBCkMDlSf46OMtumJ4sfXik//qZ
N/ReBJ23OhBuC7wPjmRq7L2A+d240z7si9SMRtZv0deKazyevq63QZzaKJeviz5W
QgrRddkEZi2G+v0BmGpVSRH7CLcshHf9Daw73NszOtiKd+hAISrkF/G/gb7h64ia
e9Mr6hUHPDQFyCUEK5Y4Skngi1Zohr0GAGQ5oMBJXPyLkQ7jcKQ=
=NVix
-----END PGP SIGNATURE-----
--- End Message ---
