Your message dated Mon, 21 Nov 2022 13:19:56 +0000
with message-id <e1ox6ik-00epuj...@fasolo.debian.org>
and subject line Bug#1024244: fixed in highway 1.0.3~git20221102.4899d11-3
has caused the Debian Bug report #1024244,
regarding highway FTCBFS: multiple reasons
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
1024244: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1024244
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: highway
Version: 1.0.3~git20221102.4899d11-2
Tags: patch
User: debian-cr...@lists.debian.org
Usertags: ftcbfs
highway fails to cross build from source for multiple reasons. The
immediate failure is forcing a build architecture compiler by exporting
the make defaults for CC and CXX. Those values are wrong for cross
compilation and seeding them from dpkg's buildtools.mk is the easiest
way to fix that without overriding user choices. Next is failure to run
tests despite DEB_BUILD_OPTIONS containing nocheck. I'm attaching a
patch fixing both of these for your convenience. It also fixes some
build vs host confusions to fix specific cross build combinations.
Helmut
diff --minimal -Nru highway-1.0.3~git20221102.4899d11/debian/changelog
highway-1.0.3~git20221102.4899d11/debian/changelog
--- highway-1.0.3~git20221102.4899d11/debian/changelog 2022-11-03
12:50:53.000000000 +0100
+++ highway-1.0.3~git20221102.4899d11/debian/changelog 2022-11-14
14:17:59.000000000 +0100
@@ -1,3 +1,13 @@
+highway (1.0.3~git20221102.4899d11-2.1) UNRELEASED; urgency=medium
+
+ * Non-maintainer upload.
+ * Fix FTCBFS: (Closes: #-1)
+ + Honour DEB_BUILD_OPTIONS=nocheck.
+ + Default CC to a cross compiler via buildtools.mk.
+ * Fix a pile of build vs host confusions.
+
+ -- Helmut Grohne <hel...@subdivi.de> Mon, 14 Nov 2022 14:17:59 +0100
+
highway (1.0.3~git20221102.4899d11-2) experimental; urgency=medium
* d/patches: Fix atomic support
diff --minimal -Nru highway-1.0.3~git20221102.4899d11/debian/rules
highway-1.0.3~git20221102.4899d11/debian/rules
--- highway-1.0.3~git20221102.4899d11/debian/rules 2022-11-03
12:49:30.000000000 +0100
+++ highway-1.0.3~git20221102.4899d11/debian/rules 2022-11-14
14:17:59.000000000 +0100
@@ -12,19 +12,21 @@
# Let's pretend to know what we are doing:
DEB_CXXFLAGS_MAINT_APPEND += -DHWY_BROKEN_EMU128=0
-ifneq (,$(filter $(DEB_BUILD_ARCH), armhf armel))
+ifneq (,$(filter $(DEB_HOST_ARCH), armhf armel))
# https://gcc.gnu.org/bugzilla/show_bug.cgi?id=77728
DEB_CXXFLAGS_MAINT_APPEND += -Wno-psabi
endif
-ifeq ($(DEB_BUILD_ARCH),$(filter $(DEB_BUILD_ARCH),armhf))
+ifeq ($(DEB_HOST_ARCH),$(filter $(DEB_HOST_ARCH),armhf))
# highway implement dynamic dipatch:
# https://github.com/google/highway/issues/891
CMAKE_EXTRA_FLAGS += -DHWY_CMAKE_ARM7:BOOL=ON
endif
+include /usr/share/dpkg/buildtools.mk
+
# HWY_RVV requires `-march=rv64gcv1p0 -menable-experimental-extensions`
-ifeq ($(DEB_BUILD_ARCH),$(filter $(DEB_BUILD_ARCH),riscv64))
+ifeq ($(DEB_HOST_ARCH),$(filter $(DEB_HOST_ARCH),riscv64))
CC=clang
CXX=clang++
endif
@@ -39,10 +41,14 @@
-DBUILD_SHARED_LIBS:BOOL=ON \
-DHWY_WARNINGS_ARE_ERRORS:BOOL=ON \
-DHWY_SYSTEM_GTEST:BOOL=ON
+ifneq (,$(filter nocheck,$(DEB_BUILD_OPTIONS)))
+CMAKE_EXTRA_FLAGS += -DBUILD_TESTING=OFF
+endif
override_dh_auto_configure-arch:
dh_auto_configure -- $(CMAKE_EXTRA_FLAGS)
+ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS)))
# run default example to check compilation ok:
override_dh_install-arch:
ifeq (,$(filter $(DEB_BUILD_ARCH),hurd-i386))
@@ -51,6 +57,7 @@
echo "CPU 'QEMU Virtual CPU version 2.5+' does not support RDTSCP,
skipping benchmark."
endif
dh_install
+endif
override_dh_clean-indep:
dh_clean debian_docs/
--- End Message ---
--- Begin Message ---
Source: highway
Source-Version: 1.0.3~git20221102.4899d11-3
Done: Mathieu Malaterre <ma...@debian.org>
We believe that the bug you reported is fixed in the latest version of
highway, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 1024...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Mathieu Malaterre <ma...@debian.org> (supplier of updated highway package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Mon, 21 Nov 2022 13:54:45 +0100
Source: highway
Architecture: source
Version: 1.0.3~git20221102.4899d11-3
Distribution: experimental
Urgency: medium
Maintainer: Debian PhotoTools Maintainers
<pkg-phototools-de...@lists.alioth.debian.org>
Changed-By: Mathieu Malaterre <ma...@debian.org>
Closes: 1024244
Changes:
highway (1.0.3~git20221102.4899d11-3) experimental; urgency=medium
.
[ Helmut Grohne ]
* Fix FTCBFS: (Closes: #1024244)
* Fix a pile of build vs host confusions.
Checksums-Sha1:
772ea6e4b997f0153b68252a8efc7228d8410c37 2311
highway_1.0.3~git20221102.4899d11-3.dsc
12113e7ad772a129563cfef4909da1ad1481313e 7268
highway_1.0.3~git20221102.4899d11-3.debian.tar.xz
f38a75013610d007b058456075b64ed2bb86717d 7227
highway_1.0.3~git20221102.4899d11-3_source.buildinfo
Checksums-Sha256:
f0618b695c32c0673556de0c9cea85beaa00bb395e5acb6120eac0be25a41d1d 2311
highway_1.0.3~git20221102.4899d11-3.dsc
a56a99f9e4668c16a88b3b17c598c43e96b2acad510b97a944cb4b12df49498c 7268
highway_1.0.3~git20221102.4899d11-3.debian.tar.xz
5392ce33dac8397a5fd71b71b9442b5ee62ce4e10cf17210162dbf9334e28c64 7227
highway_1.0.3~git20221102.4899d11-3_source.buildinfo
Files:
9249a9c0ad10ad5f79340ded02f85b1a 2311 libs optional
highway_1.0.3~git20221102.4899d11-3.dsc
03979514742446a6f1e80d0237708a39 7268 libs optional
highway_1.0.3~git20221102.4899d11-3.debian.tar.xz
9c85a6bc9c8a2ea48014725f8cdc834a 7227 libs optional
highway_1.0.3~git20221102.4899d11-3_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQJFBAEBCgAvFiEEaTNn/67NjqrNHwY7AXHhgorgk0UFAmN7dWARHG1hbGF0QGRl
Ymlhbi5vcmcACgkQAXHhgorgk0WLhxAAhgEyTSdCQejh2s8dJggVZpxbyTHhxt25
2nGPp3djaTPm2D3KXzTiRttYm0/i9wj66fqlSufb9oZBzrCX1xMF7+oU1U8gcwQ2
1BqMvt67x0MYqM0DsfXaiRj4TJFzp+MHmPqjQziPyjMel1qZDIznIDZk1S5ppG6S
Gk/U/scBOHmAtkTiv9n+jNKt21p+gb8dg3e6iA8UFFDS8bxeQ7bqgWBJhWwlZTwI
pteITciZLjNP6NZ4fAouvBxXRQ9rvIIDNugQFez51OpHeCkVjtbfqH4CD+b2uNct
S6I8HpNE+drMzlUZzJe+JCf98pFmzCq7sBX1tjo3iXR/e0OyK8nB1Ox5ujus8U7D
Rn8FC6V5rqnbVMCBnfJqvTBdObTQ54PMwdbh4Dl0ScwTAJwS2fw0+kHcGgjmlP0A
rqvvWSa3hRQzIaUqkDVP3yQxRlwl/ypfTs6lTm3uoFZH11bo7xy5dEHmGHAhHPOg
z21kyecgrWZTWWfYjF1Glk7ht9RYjTqsrJ05vrA8y8Ffw4pdFP9O7eWyjWWhbeuv
KWXIhA9WcpkoySP2qdv/l+bBxBpPy4b9G40MFYQSfBUzLEpbwWXH4Iy6zYn6ir51
hW50Ce6gzNN7HPGpFfJOs/fibXcOd4kGr1QstwI3gAOqgVmOMN8WCHu3Z775p+tJ
qtcrrPq1TPQ=
=t74L
-----END PGP SIGNATURE-----
--- End Message ---
