Your message dated Fri, 23 Sep 2022 07:03:54 +0000
with message-id <e1obcj4-00giag...@fasolo.debian.org>
and subject line Bug#951659: fixed in fai 6.0~alpha10
has caused the Debian Bug report #951659,
regarding setup-storage should allow default tmpfs settings
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
951659: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=951659
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: fai-setup-storage
Version: 5.8.4
Severity: wishlist
File: /usr/sbin/setup-storage
Tags: upstream

The setup-storage(8) command has the following grammar for tmpfs
blocks:

    volume ::= tmpfs <mountpoint> <tmpfs_size> <mount_options>
    tmpfs_size ::= <sizespec>
    sizespec ::= RAM:[[:digit:]]+%|[[:digit:]]+[kKMGTP%iB]*

This forces a line that looks like the examples in the manpage:

    tmpfs   /tmp    RAM:20% defaults
    tmpfs   /scratch        3GiB    defaults

... which is great if you want to control that. But in our
configuration, we're happy to delegate the decision of how big a tmpfs
should be to the kernel, which has its own defaults (50% of RAM at the
time of writing, I believe).

It seems there's no way to do that delegation in setup-storage(8)
right now: if I use `-` as a <sizespec>, I get the following error:

    # setup-storage -f "disk-config/gnt-fsn" -X
    Starting setup-storage 2.2
    Using config file: disk-config/gnt-fsn
    
          ERROR (line 15):  invalid tmpfs size near " - defaults disk_config
                           nvme0n1 disklabel:gpt-bios gpt_bios_part:1 bootable:2
          [...]
    
          ERROR (line 15): Invalid volume: Was expecting tmpfs size but found "-
                           defaults" instead
    
          ERROR (line 15): Invalid line: Was expecting '\n' but found "tmpfs 
/tmp -
                           defaults" instead
    Syntax error

(I'll also note the duplicate errors, with the first strangely
containing the entire configuration after the tmpfs keyword, stripped
here for brievety.)

It seems to me "-" should be allowed here, like this:

    disk_config tmpfs
    tmpfs   /tmp    -       defaults

It's allowed in fstab and just worked fine in our previous
configuration.

Thanks!

-- System Information:
Debian Release: 10.3
  APT prefers stable-debug
  APT policy: (500, 'stable-debug'), (500, 'stable'), (1, 'experimental'), (1, 
'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.19.0-8-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_CA.UTF-8, LC_CTYPE=fr_CA.UTF-8 (charmap=UTF-8), 
LANGUAGE=fr_CA.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages fai-setup-storage depends on:
ii  e2fsprogs                 1.44.5-1+deb10u3
ii  liblinux-lvm-perl         0.17-2
ii  libparse-recdescent-perl  1.967015+dfsg-2
ii  parted                    3.2-25
ii  perl                      5.28.1-6

Versions of packages fai-setup-storage recommends:
ii  lvm2   2.03.02-3
ii  mdadm  4.1-1

Versions of packages fai-setup-storage suggests:
ii  cryptsetup     2:2.1.0-5+deb10u2
ii  dmsetup        2:1.02.155-3
ii  dosfstools     4.1-2
pn  jfsutils       <none>
ii  ntfs-3g        1:2017.3.23AR.3-3
ii  reiserfsprogs  1:3.6.27-3
ii  xfsprogs       4.20.0-1

-- no debconf information

--- End Message ---
--- Begin Message ---
Source: fai
Source-Version: 6.0~alpha10
Done: Thomas Lange <la...@debian.org>

We believe that the bug you reported is fixed in the latest version of
fai, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 951...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Thomas Lange <la...@debian.org> (supplier of updated fai package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Tue, 20 Sep 2022 12:02:28 +0200
Source: fai
Architecture: source
Version: 6.0~alpha10
Distribution: experimental
Urgency: low
Maintainer: Thomas Lange <la...@debian.org>
Changed-By: Thomas Lange <la...@debian.org>
Closes: 844377 951659 977832 985303 987779 989547 990633 999739 1000572 1005745 
1006847 1010593 1010906
Changes:
 fai (6.0~alpha10) experimental; urgency=low
 .
   * add autopkgtest
   * install_packages: add support for alpnie Linux apk, add release=<name>
     feature, Closes: #844377, add pacman support
   * fetch-basefile: cuse curl instead of lftp, so https is now working
   * Commands.pm: special handling of nvme devices, Closes: #999739, quote
     variables, Closes: #977832
   * fai-mk-network: usie iproute commands instead of brctl
   * fai-make-nfsroot: add dracut modul network-legacy, Closes: #1010906
   * Exec.pm: better error message, Closes: #1005745
   * fcopy: handle broken symlinks, Closes: #985303
   * fai-chboot: add variable substitution when coping a template, add
     option -a
   * fai-kvm: add -M for creating NVMe devices
   * fai-mirror: use only first line of bpo in sources.list,
     Closes: #1006847
   * fai-diskimage: call losetup with -P, Closes: #1010593, do not remove
     VGs, deactivate them, Closes: #990633, add option -c
   * fai-cd: set TMPDIR for chroot, Closes: #1000572
   * fai-setup: create ECDSA keys
   * Fstab.pm: support tmpfs size -, this uses the system default size for
     tmpfs, Closes: #951659
   * setup-storage: add support for fstabkey:partlabel and
     fstabkey:partuuid
   * enhance disk_config format for partition label support
   * ftar: add support for zstd
   * fai: check if unshare can be used, Closes: #989547
   * subroutines: start dhclient, Closes: #987779
   * watch: update to version 4
Checksums-Sha1:
 9f44adbf4b8f49275d6d808acc6e95592d6cf5dc 2094 fai_6.0~alpha10.dsc
 57fa8acc3f7b50e5dc353c79f8485fdd4bff93e9 291080 fai_6.0~alpha10.tar.xz
 26d37f65bc27215b67b809ba1b628073792ad3f0 16303 fai_6.0~alpha10_amd64.buildinfo
Checksums-Sha256:
 12847a91b1410fc7f400a8977d453be872ac7c5a3b6342b66d5cd344b6121b27 2094 
fai_6.0~alpha10.dsc
 dd72e6e7d0ec40cae11bcabf91fc57f887ecfce079b410dcc6bd8318b6e1caba 291080 
fai_6.0~alpha10.tar.xz
 187bdb83ae6bdf22c612e13b8ce648d16f7401654759bfc12dd000c31aabc861 16303 
fai_6.0~alpha10_amd64.buildinfo
Files:
 b5bca87d27360679fd448f14074ac7d0 2094 admin optional fai_6.0~alpha10.dsc
 ad65fc06919b52efb79f0c85ec4aac90 291080 admin optional fai_6.0~alpha10.tar.xz
 c027c79188405367a845cadb97b294ee 16303 admin optional 
fai_6.0~alpha10_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJFBAEBCAAvFiEEsR7jJz9rLetSjJPaK/jZ/gdLzeQFAmMtV7ERHGxhbmdlQGRl
Ymlhbi5vcmcACgkQK/jZ/gdLzeQ5Ww//f6ytca0weRUQ1KeHfctrluQXdhqrWpVV
1XTgix0WQljisEr5ThNgtFp6y/NbLnnpIg2CwBJrTa7iSl63gqk+UE8iC3fcThEV
GNl84tFnPeL45HICAwe6E3eA99rwy/cQdTPPxYzVkwu7kadjNCBmGOja1l2E67XS
FwRSUDdSNjRBrWxZ8MxKQd4EGkmgrQLykRFKuskVsAo7WrkT6XZua9n1B+xPq84v
vksPI8uNOF3aopjvWmkv1yA2HD70rN6L49f0KjIW1NkLvWpanNeXb9K+Nq1d820Y
klClHHnwErUdS2yymAcP2WvSu8wPAzeCATwRQdwX29WzqKRe/C3ocKL6Xluldd+Q
s41hS/fFoD0cx+3qBkx1RCZJ98Ji05QPxPBEy4tbIYyvnJvaJwodlQNu+rXgRsSh
+sOeJ8jXcLsCyi4eBUuycgOguLgQHvUe+NqEjrV6aVtlb3WKM2dNXCCVSPmOLv7s
RdK85PjM+Go0Go80RUbJs4HEJk1gfO4dTOyjpwmAPJo5MxFiPMdZZsvjRTYxQJIJ
23b3yzyDoiF7wAvG9FkG8nVa/HrrKoLKjT07ZhoBiWXhcct7HOuto600N+yv0Q59
Nlr+ohGMjKKqKRoep9l+qNwQf5IhI04rNcJBIGCnOS4FOUGdMdiYpswCYIeXga9U
1X7uB993VV0=
=aMP7
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to