Your message dated Sat, 17 Sep 2022 22:49:10 +0000
with message-id <e1ozgcy-00a6os...@fasolo.debian.org>
and subject line Bug#1019369: fixed in cgit 1.2.3+git2.25.1-2
has caused the Debian Bug report #1019369,
regarding cgit: FTBFS on riscv64: t0109-git-config test failed on riscv64
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
1019369: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1019369
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: cgit
Version: 1.2.3+git2.25.1-1
Severity: normal
Tags: ftbfs, patch
User: debian-ri...@lists.debian.org
Usertags: riscv64
X-Debbugs-Cc: debian-ri...@lists.debian.org
Dear Maintainer,
cgit failed on riscv64 due to t0109-git-config test [1].
On riscv64, "strace -e access cgit-1.2.3+git2.25.1/cgit" returned
"strace: invalid system call 'access'". And when "strace cgit" on
riscv64, "faccessat(AT_FDCWD,xx,yy)" rather than "access(xx,yy)" is called.
According to the manual of "access"[2], if passed AT_FDCWD, "faccessat"
behaves same as "access" [2]. So I add "-e faccessat" for riscv64. I
have tested the patch on amd64 and riscv64.
The patch is attached below.
Regards,
Sakura286.
[1]
https://buildd.debian.org/status/fetch.php?pkg=cgit&arch=riscv64&ver=1.2.3%2Bgit2.25.1-1&stamp=1660429218
[2] https://man7.org/linux/man-pages/man2/faccessat.2.html
--- a/tests/t0109-gitconfig.sh
+++ b/tests/t0109-gitconfig.sh
@@ -15,6 +15,17 @@
exit
}
+# When 'strace cgit' on riscv64, 'faccessat(AT_FDCWD,xx,yy)' rather than
+# 'access(xx,yy)' is called. If passed AT_FDCWD, 'faccessat' behaves
+# samely as 'access'.
+
+if [ $(uname -m) != 'riscv64' ]
+then
+ syscall_access='access'
+else
+ syscall_access='faccessat'
+fi
+
test_no_home_access () {
non_existent_path="/path/to/some/place/that/does/not/possibly/exist"
while test -d "$non_existent_path"; do
@@ -24,7 +35,7 @@
-E HOME="$non_existent_path" \
-E CGIT_CONFIG="$PWD/cgitrc" \
-E QUERY_STRING="url=$1" \
- -e access -f -o strace.out cgit &&
+ -e $syscall_access -f -o strace.out cgit &&
test_must_fail grep "$non_existent_path" strace.out
}
--- End Message ---
--- Begin Message ---
Source: cgit
Source-Version: 1.2.3+git2.25.1-2
Done: Peter Colberg <pe...@colberg.org>
We believe that the bug you reported is fixed in the latest version of
cgit, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 1019...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Peter Colberg <pe...@colberg.org> (supplier of updated cgit package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Sat, 17 Sep 2022 18:19:33 -0400
Source: cgit
Architecture: source
Version: 1.2.3+git2.25.1-2
Distribution: unstable
Urgency: medium
Maintainer: Debian cgit Maintainers <team+c...@tracker.debian.org>
Changed-By: Peter Colberg <pe...@colberg.org>
Closes: 1019368 1019369
Changes:
cgit (1.2.3+git2.25.1-2) unstable; urgency=medium
.
* Do not mix output when running tests in parallel (Closes: #1019368)
* Fix FTBFS on riscv64 (Closes: #1019369)
* Bump standards version
Checksums-Sha1:
0f73a0b21d0bac3b7c8872e09355a49d00c9c540 2393 cgit_1.2.3+git2.25.1-2.dsc
5bf2178f98869bb8f55b9e994abbd489be74ce6f 20148
cgit_1.2.3+git2.25.1-2.debian.tar.xz
ab7df4f74c277e1785f06b842401c3922ba66342 6134
cgit_1.2.3+git2.25.1-2_source.buildinfo
Checksums-Sha256:
37d07b99864f17444bc8b7871cc8bb7043967fa27767dd00aaf7b221ad7eb251 2393
cgit_1.2.3+git2.25.1-2.dsc
898f1659632214d209891034c2520fb578dc487ef32e44ad6fa3696dda0fe43d 20148
cgit_1.2.3+git2.25.1-2.debian.tar.xz
b7b395a7e8a933e87e326ce33bdcd76e0dde003e3ef4d08f0da6f2717d37d32f 6134
cgit_1.2.3+git2.25.1-2_source.buildinfo
Files:
8c73186fec47dc4c1f96e820f12e84c9 2393 net optional cgit_1.2.3+git2.25.1-2.dsc
f557483fb6268dcce85f74c2de402cc3 20148 net optional
cgit_1.2.3+git2.25.1-2.debian.tar.xz
92fc8ead4d35f5ee1e77cad6fdaec51d 6134 net optional
cgit_1.2.3+git2.25.1-2_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEmDv50PAqYBQM7FKfdn4SqMkqMcsFAmMmSa8ACgkQdn4SqMkq
McukCA/+La4tkUKT8t/1U5yp6AYAXIny8njvl/nXRFRQSZ/BBpLyYNwo7E2CWJRM
40Md+Totumyd1BkRAwuBXEc9vrDPhSZmcZNvQXHEM9bGw9mpDLAYW9L86dZMVAo9
6g51z9eMmVsUv2i+DGftgyQNggBmJ6iqgUNawmjIK+ELrKi4y188RfGhAZ0322ia
e8DZxeQtJG30hGdCNvDxX8w1y28P0dLNokhhcYzmAtFRL1i5w5f7GiOcbUYjAo8R
kJP6oS4ygAgT9lwCbhjKtWTgJ9FiwqafE/et8eKnRy073TNwSVYsBCxdtYzxCx7t
Wd5oXDjzqt/RnhQZGO+be3cdxg1k7p55DcLh7lkCW5YVx5uMgs/Dlzj/wU6yjLFR
fQmlblWRV0b5WJAqd4zFtm0sRPEFwADph51cDjmWn3aCIBB+2W2iFZIJ7nMV4W76
6PbzXTzCLCc/OZiacnStDEYZ3kmCZLPtiLxrshLmBUYjKvrIYUR9rcEMA4tEjA0k
C30IIJamT2pHB5aKd3vro5UjNHLtSZtWO3A0efkU083RviMOdNMZG98cUwlughPp
nTGoNonvzpNkvFfjY8f3C8hGzxvTRU2WcG0Mzv4Z/k33c6mTmLn/4HNOMcf2trEO
ZXHDIkIPXR2s7nSQhBuClR8rdpsowXxKcCRqxcuTH9MDRiHPFLU=
=IDx9
-----END PGP SIGNATURE-----
--- End Message ---
