Your message dated Mon, 04 Jul 2022 13:34:43 +0000
with message-id <e1o8mdr-0004ow...@fasolo.debian.org>
and subject line Bug#836527: fixed in vcmi 0.99+dfsg+git20220621.54fab9f0-2
has caused the Debian Bug report #836527,
regarding /usr/games/vcmibuilder: vcmibuilder does not work with gog.com
executable
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
836527: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=836527
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: vcmi
Version: 0.98+dfsg-3
Severity: important
File: /usr/games/vcmibuilder
Tags: patch
Dear Maintainer,
when using vcmibuilder with the --gog option, it fails.
The first error message is “Could not open file "1"”.
The reason is a stray “1” on line 166 of /usr/games/vcmibuilder.
If you remove the character, vcmibuilder with --gog option works.
I have attached a fixed version of vcmibuilder.
-- System Information:
Debian Release: 8.5
APT prefers testing
APT policy: (500, 'testing')
Architecture: i386 (i686)
Kernel: Linux 3.16.0-4-686-pae (SMP w/1 CPU core)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)
Versions of packages vcmi depends on:
ii libavcodec57 7:3.1.1-2
ii libavformat57 7:3.1.1-2
ii libavutil55 7:3.1.1-2
ii libboost-atomic1.61.0 1.61.0+dfsg-2.1
ii libboost-chrono1.61.0 1.61.0+dfsg-2.1
ii libboost-date-time1.61.0 1.61.0+dfsg-2.1
ii libboost-filesystem1.61.0 1.61.0+dfsg-2.1
ii libboost-locale1.61.0 1.61.0+dfsg-2.1
ii libboost-program-options1.61.0 1.61.0+dfsg-2.1
ii libboost-system1.61.0 1.61.0+dfsg-2.1
ii libboost-thread1.61.0 1.61.0+dfsg-2.1
ii libc6 2.23-1
ii libfuzzylite5.1v5 5.1+dfsg-3.1
ii libgcc1 1:6.1.1-9
ii libminizip1 1.1-8
ii libqt5core5a 5.6.1+dfsg-3
ii libqt5gui5 5.6.1+dfsg-3
ii libqt5network5 5.6.1+dfsg-3
ii libqt5widgets5 5.6.1+dfsg-3
ii libsdl2-2.0-0 2.0.4+dfsg2-1
ii libsdl2-image-2.0-0 2.0.1+dfsg-2+b2
ii libsdl2-mixer-2.0-0 2.0.1+dfsg1-1
ii libsdl2-ttf-2.0-0 2.0.14+dfsg1-1
ii libstdc++6 6.1.1-9
ii libswscale4 7:3.1.2-1
ii zlib1g 1:1.2.8.dfsg-2+b1
Versions of packages vcmi recommends:
ii innoextract 1.6-1+b1
ii libav-tools 7:3.1.2-1
ii unshield 1.0-1
ii unzip 6.0-16+deb8u2
vcmi suggests no packages.
-- debconf information excluded
#!/bin/bash
#
# VCMI data builder script
# Extracts game data from various sources and creates a tree with the right files
#
# Authors: listed in file AUTHORS in main folder
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 2 of the License, or
# (at your option) any later version.
#
# no console arguments - print help
if [ $# -eq 0 ] ; then
print_help=true
fi
# command line parsing
# can't use system getopt which is not cross-platform (BSD/Mac)
# can't use built-in getopts which can't parse long options (too difficult to avoid - e.g. CD1/CD2)
while [ $# -gt 0 ]
do
case $1 in
--cd1) cd1_dir=$2 ; shift 2 ;;
--cd2) cd2_dir=$2 ; shift 2 ;;
--gog) gog_file=$2 ; shift 2 ;;
--data) data_dir=$2 ; shift 2 ;;
--dest) dest_dir=$2 ; shift 2 ;;
--convertMP3) useffmpeg=true; shift 1 ;;
# --download) download=true ; shift 1 ;;
--validate) validate=true ; shift 1 ;;
*) print_help=true ; shift 1 ;;
esac
done
if [[ -n "$print_help" ]]
then
echo "VCMI data builder utility"
echo "Usage: vcmibuilder <options>"
echo "Options:"
echo " --cd1 DIRECTORY " "Path to mounted first CD with Heroes 3 install files"
echo " " "Requires unshield"
echo
echo " --cd2 DIRECTORY " "Path to second CD with Heroes 3 data files."
echo
echo " --gog EXECUTABLE " "Path to gog.com executable"
echo " " "Requires innoextract ( http://constexpr.org/innoextract/ )"
echo
echo " --data DIRECTORY " "Path to installed Heroes 3 data"
echo
echo " --convertMP3 " "Convert all mp3 files into ogg/vorbis"
echo " " "Requires ffmpeg or avconv"
echo
# echo " --download " "Automatically download optional package using wget"
# echo " " "Requires wget and Internet connection"
# echo
echo " --dest DIRECTORY " "Path where resulting data will be placed. Default is ~/.local/share/vcmi"
echo
echo " --validate " "Run basic validness checks"
exit 0
fi
# test presence of program $1, $2 will be passed as parameters to test presence
test_utility ()
{
$1 $2 > /dev/null 2>&1 || { echo "$1 was not found. Please install it" 1>&2 ; exit 1; }
}
#print error message and exit
fail ()
{
$2
echo "$1" 1>&2
rm -rf "$temp_dir"
exit 1
}
# print warning to stderr.
warning ()
{
echo "$1" 1>&2
warn_user=true
}
# check if selected options are correct.
if [[ -n "$data_dir" ]]
then
if [[ -n "$gog_file" ]] || [[ -n "$cd1_dir" ]] || [[ -n "$cd2_dir" ]]
then
warning "Warning: Installed data dir was specified. Both gog and cd options will be ignored"
unset gog_file cd1_dir cd2_dir
fi
fi
if [[ -n "$gog_file" ]]
then
test_utility "innoextract"
if [[ -n "$cd1_dir" ]] || [[ -n "$cd2_dir" ]]
then
warning "Warning: Both gog and cd options were specified. cd options will be ignored"
unset cd1_dir cd2_dir
fi
fi
if [[ -n "$useffmpeg" ]]
then
ffmpeg -version > /dev/null 2>&1 && AUDIO_CONV=ffmpeg
avconv -version > /dev/null 2>&1 && AUDIO_CONV=avconv
if [[ -z "$AUDIO_CONV" ]]
then
fail "Error: neither ffmpeg nor avconv were found. Please install it."
fi
fi
if [[ -n "$cd1_dir" ]]
then
test_utility "unshield" "-V"
fi
if [[ -n "$download" ]]
then
test_utility "unzip"
fi
if [[ -z "$gog_file" ]] && [[ -z "$data_dir" ]] && ( [[ -z "$cd1_dir" ]] || [[ -z "$cd2_dir" ]] )
then
warning "Warning: Selected options will not create complete Heroes 3 data!"
fi
# if at least one warning has been printed - ask for confirmation
if [[ -n "$warn_user" ]]
then
read -p "Do you wish to continue? (y/n) " -n 1
echo #print eol
if [[ ! $REPLY =~ ^[Yy]$ ]]
then
exit 1
fi
fi
if [[ -z "$dest_dir" ]]
then
if [[ -z "$XDG_DATA_HOME" ]]
then
dest_dir="$HOME/.local/share/vcmi"
else
dest_dir="$XDG_DATA_HOME/vcmi"
fi
fi
temp_dir="$dest_dir"/buildertmp
# start installation
mkdir -p "$dest_dir"
mkdir -p "$temp_dir"
if [[ -n "$gog_file" ]]
then
# innoextract always reports error (iconv 84 error). Just test file for presence
test -f "$gog_file" || fail "Error: gog.com executable was not found!"
(gog_file=`readlink -f "$gog_file"` && cd "$temp_dir" && innoextract -s -p "$gog_file")
data_dir="$temp_dir"/app
fi
if [[ -n "$cd1_dir" ]]
then
data_dir="$temp_dir"/cddir
mkdir -p "$data_dir"
unshield -d "$data_dir" x "$cd1_dir"/_setup/data1.cab || fail "Error: failed to extract from Install Shield installer!" "rm -rf $data_dir"
# a bit tricky - different releases have different root directory. Move extracted files to data_dir
if [ -d "$data_dir"/Heroes3 ]
then
mv "$data_dir"/Heroes3/* "$data_dir"
elif [ -d "$data_dir""/Program_Files" ]
then
mv "$data_dir"/Program_Files/* "$data_dir"
elif [ -d "$data_dir""/LangInde_Program_Files" ]
then
mv "$data_dir"/LangInde_Program_Files/* "$data_dir"
else
echo "Error: failed to find extracted game files!"
echo "Extracted directories are: "
ls -la "$data_dir"
echo "Please report this on vcmi.eu"
exit 1;
fi
fi
if [[ -n "$cd2_dir" ]]
then
mkdir -p "$dest_dir"/Data
if [ -d "$cd2_dir"/heroes3 ]
then
cp "$cd2_dir"/heroes3/Data/Heroes3.vid "$dest_dir"/Data/Heroes3.vid
cp "$cd2_dir"/heroes3/Data/Heroes3.snd "$dest_dir"/Data/Heroes3-cd2.snd
else
cp "$cd2_dir"/Heroes3/Data/Heroes3.vid "$dest_dir"/Data/Heroes3.vid
cp "$cd2_dir"/Heroes3/Data/Heroes3.snd "$dest_dir"/Data/Heroes3-cd2.snd
fi
fi
if [[ -n "$data_dir" ]]
then
# this folder is named differently from time to time
# bash also has `shopt -s nocaseglob` but we don't want this to
# accidentally influence other parts of this script
# since the directory names are short, we use this pattern matching
cp -r "$data_dir"/[Dd][Aa][Tt][Aa] "$dest_dir"
cp -r "$data_dir"/[Mm][Aa][Pp][Ss] "$dest_dir"
cp -r "$data_dir"/[Mm][Pp]3 "$dest_dir"
fi
if [[ -n "$download" ]]
then
wget "http://download.vcmi.eu/core.zip"; -O "$temp_dir"/core.zip || fail "Error: failed to download VCMI archive!" "rm -f core.zip"
vcmi_archive="$temp_dir"/core.zip
fi
if [[ -n "$vcmi_archive" ]]
then
echo "decompressing $vcmi_archive"
unzip -qo "$vcmi_archive" -d "$dest_dir" || fail "Error: failed to extract VCMI archive!"
fi
if [[ -n "$useffmpeg" ]]
then
# now when all music files were installed convert them to ogg
echo "Converting mp3 files..."
OIFS="$IFS"
IFS=$'\n'
for file in `find "$dest_dir" -type f -iname "*.mp3"`
do
echo "Converting $file"
ogg=${file%.*}
$AUDIO_CONV -y -i "$file" -acodec libvorbis "$ogg".ogg 2>/dev/null || fail "Error: failed to convert $file to ogg/vorbis using $AUDIO_CONV" "rm -f "$ogg".ogg"
rm -f $file
done
IFS="$OIFS"
fi
if [[ -n "$validate" ]]
then
test -f "$dest_dir"/Data/H3bitmap.lod || fail "Error: Heroes 3 data files are missing!"
test -f "$dest_dir"/Data/H3sprite.lod || fail "Error: Heroes 3 data files are missing!"
test -f "$dest_dir"/Data/VIDEO.VID || fail "Error: Heroes 3 data files (CD2) are missing!"
test -d "$dest_dir"/Mods/vcmi/Data || fail "Error: VCMI data files are missing!"
fi
rm -rf "$temp_dir"
--- End Message ---
--- Begin Message ---
Source: vcmi
Source-Version: 0.99+dfsg+git20220621.54fab9f0-2
Done: Johannes Schauer Marin Rodrigues <jo...@debian.org>
We believe that the bug you reported is fixed in the latest version of
vcmi, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 836...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Johannes Schauer Marin Rodrigues <jo...@debian.org> (supplier of updated vcmi
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Mon, 04 Jul 2022 15:12:18 +0200
Source: vcmi
Architecture: source
Version: 0.99+dfsg+git20220621.54fab9f0-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Games Team <pkg-games-de...@lists.alioth.debian.org>
Changed-By: Johannes Schauer Marin Rodrigues <jo...@debian.org>
Closes: 836527 991460 1013419
Changes:
vcmi (0.99+dfsg+git20220621.54fab9f0-2) unstable; urgency=medium
.
* move from experimental to unstable
* the latest upstream git commit also fixes vcmibuilder --gog (closes:
#836527)
.
vcmi (0.99+dfsg+git20220621.54fab9f0-1) experimental; urgency=medium
.
* Still no release, so we package the latest git commit.
- link with tbb (closes: #991460)
- compatibility with ffmpeg 5.0.1 (closes: #1013419)
* refresh patches
* fix my name
* run wrap-and-sort -astb
* debian/control: add B-D on libtbb-dev, libluajit-5.1-dev, googletest,
libgmock-dev
* debian/rules: disable tests to prevent compilation errors
Checksums-Sha1:
ff94d7ebed3102f3568eba4c7f49b04ca4319ec1 2647
vcmi_0.99+dfsg+git20220621.54fab9f0-2.dsc
8960f3f44f773f657cc9db6e364ae28160dd7ba2 8672
vcmi_0.99+dfsg+git20220621.54fab9f0-2.debian.tar.xz
Checksums-Sha256:
4d69f06145466bddfaa07ca8eabe0df79a7818c6ea3907b44e5302d11d45f2d7 2647
vcmi_0.99+dfsg+git20220621.54fab9f0-2.dsc
f3efa30a2e75aa8a6fc625a99cd09d21b433d68be0a35b44c3e1b49283dc8fc2 8672
vcmi_0.99+dfsg+git20220621.54fab9f0-2.debian.tar.xz
Files:
b0a954dd1abc6f41c67416dd0111ff22 2647 contrib/games optional
vcmi_0.99+dfsg+git20220621.54fab9f0-2.dsc
e7b9921a73e45dc9693f816dbffe7651 8672 contrib/games optional
vcmi_0.99+dfsg+git20220621.54fab9f0-2.debian.tar.xz
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEElFhU6KL81LF4wVq58sulx4+9g+EFAmLC53wACgkQ8sulx4+9
g+GYZhAAsmhNQogkhPMIeEUC1pr/4FhjiN8eEzGATiOB2D3xS0izNqnkX4WvJU1o
h71hS22LRor0Ust67xgVKNregbkkxNoccVr9x4gKj+V8QNQF2hK5AtXv/jaii2vg
TG5r/XrDZCL1Cx5tCFaGWgjAxWfcqHHxvf9dkuaSiCRv9re0w/+ZYycsAd0+NGKt
J2W/H9o/wP4nkwtK8leY8LdufIxVBU0EW2IXZ3c+yJToMJYftoHK7+gTie0Vpoaq
qERJDtP0G4OVYxjNDMr12ORmBQloeXgzMRaps3lrIbxkcjr0VwEVlcLNK0aeioTp
M8M6hDsB1tNVxQfFyJ4DnCrZ28dPMw2yGGnS1jiThQZmzIwxNjaSwSChm68aDdBH
iJgpMA4N/pe+MnioGgvL+ZW0SNKloC33W0Xzb9lsCutDg61Ib7McHztycoTRJfTA
Wl/iUS1FXCmNiYBt8KzC8kEhoZNgLOgdQ7gY2o5CdE1jJLExqT0QXJ6NhW9SlzJf
23xOtpGznxsYyl+KLZM9C0Ww/fupOTjGqvSXqNqyJQ4RlRYX6qxtFquABjcD1VE7
Lr6yUNIajbLiamDClIw8VycLoPj3d7M/KR5FBBj4Sq1+rnge6molvRTUUpj0JFId
6NC6jIKszlrbjg5mmz2Mx2bQgV+yt6dzKdHJRKzNpZmyUhRLmoc=
=issW
-----END PGP SIGNATURE-----
--- End Message ---
