Your message dated Wed, 10 Feb 2021 03:33:37 +0000 with message-id <e1l9gg1-0007nf...@fasolo.debian.org> and subject line Bug#971014: fixed in e2fsprogs 1.46.1-1 has caused the Debian Bug report #971014, regarding Reproducible bug in inline_data handling with ACL to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 971014: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=971014 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
--- Begin Message ---Package: e2fsprogs Version: 1.46~WIP.2019.10.03-1 Severity: normal File: /sbin/mke2fs X-Debbugs-Cc: j...@joshtriplett.org This bug exists in both 1.45.6-1 (sid) and 1.46~WIP.2019.10.03-1 (experimental). In the course of creating some filesystems containing Debian installations using `mke2fs -d`, I managed to find a bug in the `inline_data` handling, which seems to apply to files containing ACLs. On a default Debian installation, /var/log/journal triggered this problem. I managed to create a minimal test case. To reproduce: mkdir -p target/testdir setfacl --restore=- <<EOF # file: target/testdir/ user::rwx group::r-x group:adm:r-x mask::r-x other::r-x default:user::rwx default:group::r-x default:group:adm:r-x default:mask::r-x default:other::r-x EOF mke2fs -b 4096 -I 256 -O sparse_super2,inline_data,^has_journal -d target disk.img 8M and then run: e2fsck -n -f disk.img This will show: e2fsck 1.46-WIP (03-Oct-2019) Pass 1: Checking inodes, blocks, and sizes Inode 12 has INLINE_DATA_FL flag but extended attribute not found. Truncate? no Pass 2: Checking directory structure Pass 3: Checking directory connectivity Pass 4: Checking reference counts Pass 5: Checking group summary information disk.img: ********** WARNING: Filesystem still has errors ********** disk.img: 12/2048 files (0.0% non-contiguous), 137/2048 blocks And the kernel ext4 implementation will fail to handle that inode, with a message like this: EXT4-fs error (device loop0): __ext4_iget:4776: inode #3215: block 56: comm ls: invalid block The size of 8M doesn't matter; the issue reproduces with other sizes. /etc/mke2fs.conf is unchanged from the defaults. `tune2fs -l disk.img` shows the following: tune2fs 1.46-WIP (03-Oct-2019) Filesystem volume name: <none> Last mounted on: <not available> Filesystem UUID: 931e3151-83db-4c33-be5f-655c9323fab4 Filesystem magic number: 0xEF53 Filesystem revision #: 1 (dynamic) Filesystem features: ext_attr resize_inode dir_index sparse_super2 filetype inline_data sparse_super large_file Filesystem flags: signed_directory_hash Default mount options: user_xattr acl Filesystem state: clean Errors behavior: Continue Filesystem OS type: Linux Inode count: 2048 Block count: 2048 Reserved block count: 102 Free blocks: 1911 Free inodes: 2036 First block: 0 Block size: 4096 Fragment size: 4096 Blocks per group: 32768 Fragments per group: 32768 Inodes per group: 2048 Inode blocks per group: 128 Filesystem created: Sat Sep 26 00:50:53 2020 Last mount time: n/a Last write time: Sat Sep 26 00:50:53 2020 Mount count: 0 Maximum mount count: -1 Last checked: Sat Sep 26 00:50:53 2020 Check interval: 0 (<none>) Reserved blocks uid: 0 (user root) Reserved blocks gid: 0 (group root) First inode: 11 Inode size: 256 Required extra isize: 32 Desired extra isize: 32 Default directory hash: half_md4 Directory Hash Seed: df46d104-ed26-4cea-ac61-0feff2a54622 -- System Information: Debian Release: bullseye/sid APT prefers unstable-debug APT policy: (500, 'unstable-debug'), (500, 'unstable'), (1, 'experimental-debug'), (1, 'experimental') Architecture: amd64 (x86_64) Kernel: Linux 5.8.0-2-amd64 (SMP w/4 CPU threads) Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) Versions of packages e2fsprogs depends on: ii libblkid1 2.36-3+b1 ii libc6 2.31-3 ii libcom-err2 1.45.6-1 ii libext2fs2 1.46~WIP.2019.10.03-1 ii libss2 1.45.6-1 ii libuuid1 2.36-3+b1 ii logsave 1.45.6-1 Versions of packages e2fsprogs recommends: pn e2fsprogs-l10n <none> Versions of packages e2fsprogs suggests: pn e2fsck-static <none> pn fuse2fs <none> pn gpart <none> ii parted 3.3-4 -- no debconf information
--- End Message ---
--- Begin Message ---Source: e2fsprogs Source-Version: 1.46.1-1 Done: Theodore Y. Ts'o <ty...@mit.edu> We believe that the bug you reported is fixed in the latest version of e2fsprogs, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 971...@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Theodore Y. Ts'o <ty...@mit.edu> (supplier of updated e2fsprogs package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmas...@ftp-master.debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Format: 1.8 Date: Tue, 09 Feb 2021 17:36:02 -0500 Source: e2fsprogs Architecture: source Version: 1.46.1-1 Distribution: unstable Urgency: medium Maintainer: Theodore Y. Ts'o <ty...@mit.edu> Changed-By: Theodore Y. Ts'o <ty...@mit.edu> Closes: 966686 971014 Changes: e2fsprogs (1.46.1-1) unstable; urgency=medium . * Drop transitional packages libcomerr2, e2fslibs, and e2fslibs-dev * Fix a bug in libext2fs and debugfs when trying to set an extended attribute will result in a seg fault. * Fix e2fsck so it properly accepts large_dir directories which are greater than 4GB in size. * Fix mke2fs -d so it correctly handles important a directory or small file which is stored using inline_data and contains an ACL or extended attribute. (Closes: #971014) * Add build profiles noudeb and pkg.e2fsprogs.no-static (Closes: #966686) * Update the Czech, French, Malay, Polish, Portuguese, Sweedish, and Ukranian translations from the translation project. . e2fsprogs (1.46.0-1) experimental; urgency=medium . * New upstream release * Add support for the new fast_commit feature. (Requires Linux version 5.10 or higher) * Add support for the new stable_inodes feature which is needed to support some the fscrypt siphash algorithm. * Add support for file systems that have both case folding and encryption enabled. (Not yet upstream, but used in some Android handsets.) * The fuse2fs program now supports the "norecovery" which omits replying the journal and mounts the file system read-only. * Bitmap loading is now done using multiple threads which can speed up debugfs, dumpe2fs, and e2fsck on very large file systems. * E2fsck now will check file names on file systems with case folding enabled to make sure the characters are valid UTF-8 characters. This is done for file systems which enforce strict encodings, and optionally if the extended "check_encoding" option is requested. * E2fsck will properly handle checking for duplicated file names when case folding is enabled. * E2fsck will now find and fix file system corruptions when the encrypted files have a different policy from their containing directory. * The "htree" command in debugfs now displays the metadata checksums for hash tree index blocks. * Fix various bugs where a maliciously corrupted file systems could case e2fsck and other e2fsprogs programs to crash. * Dumpe2fs will print the error code that Linux kernels newer than v5.6 will save to indicate the class of error which triggered the ext4_error event. * E2fsprogs programs (in particular, fuse2fs) can now update htree directories without clearing the htree index. * Tune2fs will properly recalculate directory block checksums when clearing the dir_index feature. * Fix a bug in e2fsck directory rehashing which could fail with ENOSPC because it doesn't take into account the space needed for the metadata checksum, and doesn't create a sufficiently deep index tree. * Clarify the e2fsck messages when it resets the directory link count when it is set to the overflow value but it is no longer needed. * Mke2fs now sets the s_overhead_cluster field, so that the kernel doesn't need to calculate it at mount time. This speeds up mounting very large file systems. * Speed up mke2fs when creating large bigalloc file systems by optimizing ext2fs_convert_subcluster_bitmap(). * The filefrag program can now request the kernel to display the extent status cache by using "filefrag -E". (This requires Linux version 5.4 or newer.) Checksums-Sha1: e4f80b028bd5e0d6711e16b77ae7aa5315e7d20b 2842 e2fsprogs_1.46.1-1.dsc dfd7f718f8f4bd57498c68b41f45431b6bd5bb70 9490551 e2fsprogs_1.46.1.orig.tar.gz c46eb2c3fca663190a18f602e50a65b4a7467e2b 488 e2fsprogs_1.46.1.orig.tar.gz.asc d7f72859c75b187c966107b955b97b136cd7f5dd 81932 e2fsprogs_1.46.1-1.debian.tar.xz Checksums-Sha256: bb84dbacf687767e01899c25e1913c48112b4e64a4fc15c0239e21df57997313 2842 e2fsprogs_1.46.1-1.dsc 49630dc777a808dc67312fa289dca65b9d2dbad80c8267f3b9d437b7167774e4 9490551 e2fsprogs_1.46.1.orig.tar.gz f242d6916bc6c135d74f3c6662a62648ee4f18de16bad71152ce8061e131b316 488 e2fsprogs_1.46.1.orig.tar.gz.asc 8d64f5db2f96c8abdca8e400c1154ac21a33a157d00d792683ec99889dcc499e 81932 e2fsprogs_1.46.1-1.debian.tar.xz Files: b25c89b5a345c7d1d8bd9ef1a288eaa2 2842 admin required e2fsprogs_1.46.1-1.dsc 8c52585522b7ca6bdae2bdecba27b3a4 9490551 admin required e2fsprogs_1.46.1.orig.tar.gz 691e01ebb60857dae757787cbbc907bc 488 admin required e2fsprogs_1.46.1.orig.tar.gz.asc 8773c27b92ff445aa755dd2aca21f2b1 81932 admin required e2fsprogs_1.46.1-1.debian.tar.xz -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEK2m5VNv+CHkogTfJ8vlZVpUNgaMFAmAjTzQACgkQ8vlZVpUN gaPhQQgAo0sis2k6/9HLy/NcLOSlf7SpkMIaGcaJdJphGSbsF4x+jlsYcm45ZpfN MmShaJclGDMwe3she3HBmySLUb3F8OKDKbH1oCF3TU1+bUNNWmTvjB0ASFRmUshD ykEbzBlBRrpMhUVvaZEeFSOzsQL1BOxNKPlmOv32/ac1aBBDtIpm7JDyc22eEF8M CzHSOLYSTbFymRCr5Sh2kkALzd+u7QTXbIVRUNFYe/5nVRx1qYm1/dbAaBeaOIf7 8IMDHCJv9Xx2bkQUDebgbHXX3KMHJmbSp4K0BA2LqF3svQ78W/1Q30UNidVxyJ/h LB7g2SoYbT4vzWrI0e3kan0Y3OPG2w== =Ikew -----END PGP SIGNATURE-----
--- End Message ---
