Your message dated Sun, 14 Oct 2018 18:34:50 +0000
with message-id <e1gble2-0000h1...@fasolo.debian.org>
and subject line Bug#910984: fixed in dunst 1.3.2-1
has caused the Debian Bug report #910984,
regarding dunst FTCBFS: uses the build architecture pkg-config
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
910984: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=910984
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: dunst
Version: 1.3.0-3
Tags: patch
User: helm...@debian.org
Usertags: rebootstrap
dunst fails to cross build from source, because it uses the build
architecture pkg-config. The upstream Makefile hard codes plain
"pkg-config" and that fails to find the relevant .pc files. Making it
substitutable via $PKG_CONFIG partially solves that, but the Makefile
wants a working pkg-config even for make distclean, but debhelper only
supplies it for dh_auto_build. Thus debian/rules needs to export it
explicitly. After doing both, dunst cross builds successfully. Please
consider applying the attached patch.
Helmut
diff --minimal -Nru dunst-1.3.0/debian/changelog dunst-1.3.0/debian/changelog
--- dunst-1.3.0/debian/changelog 2018-08-05 19:27:16.000000000 +0200
+++ dunst-1.3.0/debian/changelog 2018-10-14 11:43:02.000000000 +0200
@@ -1,3 +1,12 @@
+dunst (1.3.0-3.1) UNRELEASED; urgency=medium
+
+ * Non-maintainer upload.
+ * Fix FTCBFS: (Closes: #-1)
+ + cross.patch: Make pkg-config substitutable.
+ + rules: Supply $PKG_CONFIG for all targets.
+
+ -- Helmut Grohne <hel...@subdivi.de> Sun, 14 Oct 2018 11:43:02 +0200
+
dunst (1.3.0-3) unstable; urgency=medium
[ Pascal De Vuyst ]
diff --minimal -Nru dunst-1.3.0/debian/patches/cross.patch
dunst-1.3.0/debian/patches/cross.patch
--- dunst-1.3.0/debian/patches/cross.patch 1970-01-01 01:00:00.000000000
+0100
+++ dunst-1.3.0/debian/patches/cross.patch 2018-10-14 11:42:21.000000000
+0200
@@ -0,0 +1,39 @@
+--- dunst-1.3.0.orig/Makefile
++++ dunst-1.3.0/Makefile
+@@ -19,22 +19,22 @@
+ endif
+ endif
+
+-SERVICEDIR_DBUS ?= $(shell pkg-config dbus-1
--variable=session_bus_services_dir)
++SERVICEDIR_DBUS ?= $(shell $(PKG_CONFIG) dbus-1
--variable=session_bus_services_dir)
+ SERVICEDIR_DBUS := ${SERVICEDIR_DBUS}
+ ifeq (,${SERVICEDIR_DBUS})
+ $(error "Failed to query pkg-config for package 'dbus-1'!")
+ endif
+
+ ifneq (0,${SYSTEMD})
+-SERVICEDIR_SYSTEMD ?= $(shell pkg-config systemd
--variable=systemduserunitdir)
++SERVICEDIR_SYSTEMD ?= $(shell $(PKG_CONFIG) systemd
--variable=systemduserunitdir)
+ SERVICEDIR_SYSTEMD := ${SERVICEDIR_SYSTEMD}
+ ifeq (,${SERVICEDIR_SYSTEMD})
+ $(error "Failed to query pkg-config for package 'systemd'!")
+ endif
+ endif
+
+-LIBS := $(shell pkg-config --libs ${pkg_config_packs})
+-INCS := $(shell pkg-config --cflags ${pkg_config_packs})
++LIBS := $(shell $(PKG_CONFIG) --libs ${pkg_config_packs})
++INCS := $(shell $(PKG_CONFIG) --cflags ${pkg_config_packs})
+
+ ifneq (clean, $(MAKECMDGOALS))
+ ifeq ($(and $(INCS),$(LIBS)),)
+--- dunst-1.3.0.orig/config.mk
++++ dunst-1.3.0/config.mk
+@@ -19,6 +19,7 @@
+ CFLAGS_DEBUG := -O0
+ LDFLAGS_DEBUG :=
+
++PKG_CONFIG ?= pkg-config
+ pkg_config_packs := dbus-1 \
+ gio-2.0 \
+ gdk-pixbuf-2.0 \
diff --minimal -Nru dunst-1.3.0/debian/patches/series
dunst-1.3.0/debian/patches/series
--- dunst-1.3.0/debian/patches/series 2018-08-05 19:27:16.000000000 +0200
+++ dunst-1.3.0/debian/patches/series 2018-10-14 11:37:20.000000000 +0200
@@ -1,2 +1,3 @@
example_path.patch
makefile.patch
+cross.patch
diff --minimal -Nru dunst-1.3.0/debian/rules dunst-1.3.0/debian/rules
--- dunst-1.3.0/debian/rules 2018-08-05 19:27:16.000000000 +0200
+++ dunst-1.3.0/debian/rules 2018-10-14 11:43:02.000000000 +0200
@@ -12,6 +12,8 @@
export DEB_BUILD_MAINT_OPTIONS = hardening=+all
DPKG_EXPORT_BUILDFLAGS = 1
include /usr/share/dpkg/buildflags.mk
+-include /usr/share/dpkg/buildtools.mk
+export PKG_CONFIG ?= pkg-config
override_dh_auto_install:
dh_auto_install -- PREFIX=/usr
--- End Message ---
--- Begin Message ---
Source: dunst
Source-Version: 1.3.2-1
We believe that the bug you reported is fixed in the latest version of
dunst, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 910...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Michael Stapelberg <stapelb...@debian.org> (supplier of updated dunst package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Sun, 14 Oct 2018 20:16:04 +0200
Source: dunst
Binary: dunst
Architecture: source
Version: 1.3.2-1
Distribution: unstable
Urgency: medium
Maintainer: Michael Stapelberg <stapelb...@debian.org>
Changed-By: Michael Stapelberg <stapelb...@debian.org>
Description:
dunst - dmenu-ish notification-daemon
Closes: 910984
Changes:
dunst (1.3.2-1) unstable; urgency=medium
.
[ Ondřej Nový ]
* d/copyright: Use https protocol in Format field
* d/rules: Remove trailing whitespaces
.
[ Michael Stapelberg ]
* delete gbp.conf to get rid of pristine-tar
* New upstream version 1.3.2
* drop debian/patches/makefile.patch (applied upstream)
* debian/patches/cross.patch: make pkg-config substitutable
* debian/rules: supply $PKG_CONFIG for all targets
(Closes: #910984)
Checksums-Sha1:
46c934dadefb611a99314cea52c63e5407bd385f 1994 dunst_1.3.2-1.dsc
cde0832d3a03c6942808ff3650236ef068e92503 121575 dunst_1.3.2.orig.tar.gz
a87d9496390a723adb19aec99a26d508ec02bfc5 4436 dunst_1.3.2-1.debian.tar.xz
694a4c10bb8ec94e2866d92140861a9ab056d609 11268 dunst_1.3.2-1_amd64.buildinfo
Checksums-Sha256:
d7695fd1e2598b1418cd6e9a0df5857c30ada5216270b1d252fa4d38c67ac4bd 1994
dunst_1.3.2-1.dsc
aab6e8fb1105a64153eee1db85d00ddb807994f03f7222aa46d40e3f3846d28a 121575
dunst_1.3.2.orig.tar.gz
96916600a12022aac203e2b8203d1ad628ca61311aa1f22f7218a5b91f3cf88e 4436
dunst_1.3.2-1.debian.tar.xz
24db06d3c490ced40bb6538e3f46ed84f347c271939805ce0d8ed0a7c4eebd88 11268
dunst_1.3.2-1_amd64.buildinfo
Files:
8f980455c737d94d273280eabf79c78b 1994 x11 optional dunst_1.3.2-1.dsc
68ad9fd1dab537d7a1ad93c899c50278 121575 x11 optional dunst_1.3.2.orig.tar.gz
cb6e19117a5b6bff76f4cc9e79ad5c4d 4436 x11 optional dunst_1.3.2-1.debian.tar.xz
2224e62478905d950e135633235e783e 11268 x11 optional
dunst_1.3.2-1_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCgAdFiEEQk4U1wPnxtQ9nW82TnFg7UrI7h0FAlvDiL8ACgkQTnFg7UrI
7h0ECA/+MtzgjO7BbjSbYdJbmNN6qgAgMMHG+z06Kjfs8hWChNrGtDgXlyvSU+7K
/7MjwTKDkMgWEPGG/eB8QGmoAgNaP3Fe7QX3PtA1KBq6RYs7QTRBvPP8yXGouo8w
bvDrnNumBQxNoP0eDd89Um5VBtfM04zzDA0zjjkbo9GEOxb/2rPJzt7nhMZk75Q0
+A4GPdzOCjpQOGiHuLTMMqozCkLWamV06/eCobi0adf7pS3n9L+5FwUOpXUgKqk8
rSt+pUZU9wtPOT2fLaPxLPwow4tJUR3G08gkdNRBhkl3IX3A2pGrf3jyzzFvhBcT
wMaImiAQfrnTLtCUXdQxaEm9XtBlCFtfScYqy4xgRnmlpZZIuIYthoJ2aCNJY7Ir
I2SfnAt1ReD9iZVh/pm3kz/6S1peq4FrbjDY6mKOm/zOiZk07Vdg76jbLbllVE4G
tnzmvaejY6xc48Pa+9aVykSStzf6NAd74nSJN2/OZuk0FChC5S8rcXEAu/gtcrjd
bq1mGtHoYX2mhI9GFnG7CaLDiMxWhv0po8Ny4cvWncPGjJhX6+OZJg0vMkauk5YU
WQ9My1sN58DJRw5h/S3R7r9hVfpKLmKCFmDmgd9B5ujM60H8A+CEeiYfAsD5yqvW
WbTyBx94qcKRETsX1bbhDXNuOG3pYJTMOWLFbo1RV/XhBzsJ/oc=
=qeRP
-----END PGP SIGNATURE-----
--- End Message ---