Your message dated Thu, 29 Dec 2016 15:04:16 +0000
with message-id <e1cmcfc-0004j3...@fasolo.debian.org>
and subject line Bug#816394: fixed in elfutils 0.168-0.2
has caused the Debian Bug report #816394,
regarding elfutils: FTBFS[!linux] with gcc-6: unused const, functions
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
816394: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=816394
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: elfutils
Version: 0.165-3
Severity: important
Tags: patch

Hi,

elfutils will FTBFS on kfreebsd (and I suspect on hurd) with gcc-6,
because there is an unused const and several unused, unexported stub
functions in linux-pid-attach.c inside a code block guarded by
#ifndef __linux__

A patch is attached that removes the unused code.  I tested this on
kfreebsd-amd64, where all tests pass except for the skipped ones, and
dwfl-proc-attach correctly states "dwfl_linux_proc_attach unsupported"
as before.

Thank you!

-- System Information:
Debian Release: stretch/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: kfreebsd-amd64 (x86_64)

Kernel: kFreeBSD 10.1-0-amd64
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Subject: libdwfl: clean up unused code for non-Linux GNU platforms
From: Steven Chamberlain <ste...@pyro.eu.org>
Date: Tue, 01 Mar 2016 13:32:37 +0000

For non-Linux GNU platforms (like kFreeBSD, Hurd), linux-pid-attach.c
had some stub functions that are not used or exported.  Since gcc-6,
having these caused compiler errors due to -Wall -Werror:

linux-pid-attach.c:479:36: error: 'pid_thread_callbacks' defined but not used [-Werror=unused-const-variable=]

linux-pid-attach.c:474:1: error: 'pid_thread_detach' defined but not used [-Werror=unused-function]
linux-pid-attach.c:461:1: error: 'pid_detach' defined but not used [-Werror=unused-function]
linux-pid-attach.c:452:1: error: 'pid_set_initial_registers' defined but not used [-Werror=unused-function]
linux-pid-attach.c:441:1: error: 'pid_memory_read' defined but not used [-Werror=unused-function]
linux-pid-attach.c:420:1: error: 'pid_getthread' defined but not used [-Werror=unused-function]
linux-pid-attach.c:410:1: error: 'pid_next_thread' defined but not used [-Werror=unused-function]

This part of the source file is guarded by #ifndef __linux__

--- a/libdwfl/linux-pid-attach.c
+++ b/libdwfl/linux-pid-attach.c
@@ -406,27 +406,6 @@
 
 #else	/* __linux__ */
 
-static pid_t
-pid_next_thread (Dwfl *dwfl __attribute__ ((unused)),
-	         void *dwfl_arg __attribute__ ((unused)),
-		 void **thread_argp __attribute__ ((unused)))
-{
-  errno = ENOSYS;
-  __libdwfl_seterrno (DWFL_E_ERRNO);
-  return -1;
-}
-
-static bool
-pid_getthread (Dwfl *dwfl __attribute__ ((unused)),
-	       pid_t tid __attribute__ ((unused)),
-	       void *dwfl_arg __attribute__ ((unused)),
-	       void **thread_argp __attribute__ ((unused)))
-{
-  errno = ENOSYS;
-  __libdwfl_seterrno (DWFL_E_ERRNO);
-  return false;
-}
-
 bool
 internal_function
 __libdwfl_ptrace_attach (pid_t tid __attribute__ ((unused)),
@@ -437,32 +416,6 @@
   return false;
 }
 
-static bool
-pid_memory_read (Dwfl *dwfl __attribute__ ((unused)),
-                 Dwarf_Addr addr __attribute__ ((unused)),
-	         Dwarf_Word *result __attribute__ ((unused)),
-	         void *arg __attribute__ ((unused)))
-{
-  errno = ENOSYS;
-  __libdwfl_seterrno (DWFL_E_ERRNO);
-  return false;
-}
-
-static bool
-pid_set_initial_registers (Dwfl_Thread *thread __attribute__ ((unused)),
-			   void *thread_arg __attribute__ ((unused)))
-{
-  errno = ENOSYS;
-  __libdwfl_seterrno (DWFL_E_ERRNO);
-  return false;
-}
-
-static void
-pid_detach (Dwfl *dwfl __attribute__ ((unused)),
-	    void *dwfl_arg __attribute__ ((unused)))
-{
-}
-
 void
 internal_function
 __libdwfl_ptrace_detach (pid_t tid __attribute__ ((unused)),
@@ -470,22 +423,6 @@
 {
 }
 
-static void
-pid_thread_detach (Dwfl_Thread *thread __attribute__ ((unused)),
-		  void *thread_arg __attribute__ ((unused)))
-{
-}
-
-static const Dwfl_Thread_Callbacks pid_thread_callbacks =
-{
-  pid_next_thread,
-  pid_getthread,
-  pid_memory_read,
-  pid_set_initial_registers,
-  pid_detach,
-  pid_thread_detach,
-};
-
 int
 dwfl_linux_proc_attach (Dwfl *dwfl __attribute__ ((unused)),
 			pid_t pid __attribute__ ((unused)),

--- End Message ---
--- Begin Message ---
Source: elfutils
Source-Version: 0.168-0.2

We believe that the bug you reported is fixed in the latest version of
elfutils, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 816...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Matthias Klose <d...@debian.org> (supplier of updated elfutils package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Thu, 29 Dec 2016 14:23:54 +0100
Source: elfutils
Binary: elfutils libelf1 libelf-dev libdw-dev libdw1 libasm1 libasm-dev
Architecture: source
Version: 0.168-0.2
Distribution: unstable
Urgency: medium
Maintainer: Kurt Roeckx <k...@roeckx.be>
Changed-By: Matthias Klose <d...@debian.org>
Description:
 elfutils   - collection of utilities to handle ELF objects
 libasm-dev - libasm development libraries and header files
 libasm1    - library with a programmable assembler interface
 libdw-dev  - libdw1 development libraries and header files
 libdw1     - library that provides access to the DWARF debug information
 libelf-dev - libelf1 development libraries and header files
 libelf1    - library to read and write ELF files
Closes: 816394
Changes:
 elfutils (0.168-0.2) unstable; urgency=medium
 .
   * debian/copyright: Update to the current licensing, as introduced
     with elfutils 0.154.
   * Drop the m68k_backend.diff patch.
 .
 elfutils (0.168-0.1) experimental; urgency=medium
 .
   * Non-maintainer upload.
   * New upstream release
     - m68k_backend.diff: Don't apply.
     - testsuite-amd64-fix-backtrace-native.patch: Remove, applied upstream.
     - Refresh patches.
     - Build failure on non Linux targets fixed. Closes: #816394.
   * Update libdw1 symbols file.
   * Improve DEB_BUILD_OPTIONS=nocheck handling (Helmut Grohne). See #832456.
     - Don't treat DEB_BUILD_OPTIONS=casinocheck as nocheck.
     - Don't default to nocheck for cross building.
     - Annotate Build-Depends: gcc-multilib with <!nocheck> profile.
   * Update reference to new sourceware.org home.
Checksums-Sha1:
 529598aab09138442c1ce6f7a91524deb666bdc9 2332 elfutils_0.168-0.2.dsc
 507a350877ad613071a2ff7956fb5e4739b79f2f 36564 elfutils_0.168-0.2.debian.tar.xz
Checksums-Sha256:
 55e6a746a00cdcef3c389f2caa09e6b6c82b888d3182ee5bfd63df3413431796 2332 
elfutils_0.168-0.2.dsc
 8998c51b202ed2efc7b9a3906f0926b8f350b0e0071cf86bb9c06a3aa6d3864e 36564 
elfutils_0.168-0.2.debian.tar.xz
Files:
 ea5c2d6f8bd4bc0ca72e3f0401990c14 2332 libs optional elfutils_0.168-0.2.dsc
 d711a181ae1fa2a43cb647d51bcd21bc 36564 libs optional 
elfutils_0.168-0.2.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQJEBAEBCAAuFiEE1WVxuIqLuvFAv2PWvX6qYHePpvUFAlhlFOwQHGRva29AZGVi
aWFuLm9yZwAKCRC9fqpgd4+m9YUAD/4iRKkruyqnv6YAgaYlLeLbhi5v2YcXY+e/
QG3dPC6WYz9WDPxRvtsuSHd6dIPQ8oiolmWnqkrKZt1y7xAJ2YNv6X6BaQ/9a7sy
BDtPsReSnoaFpfJl6ohyMP06t4ZQSHR9ieEarzprOIqoI0kylUWOiUIc1peUkH5q
xczcTI+29NDyG1o5Jnoypz/HGeVRQ4wDT3QTkG1l8HSQNUOYEdtjJ4kdogiWVhZf
br/NENFwH5X1hSY1OVwelMvNaYnbSuQNdA6sgQRQXE2nIbHoBsLrGldBMKUl1v+g
TMXX6pMIV0uH8o4UGtMYCnUQL8YKcdMFYoFYutsLSjQQW3N02f4TPfwyN+js9cHX
b30hhLIKbTbWeyOSfP9II7xkIIOXso/Gm6gtAPNvcHleLg3brKwOEsMAyjmyQZ0J
QAAfmc0zz2HU1KM+xbfN8pS0q0BLoN0GG2qcaZUQi/mpnhYE04o43HHVn40LVR/8
W5d72i6uyG7FB3Ardt87zxVJIF4oR0x5vq1rcZ9n/JDcxQDsCQoX/VzwxPBAK6PU
+tQFYSEMD067Nz/gu2yMGox4TGGnnf20qQsngbc8TBKy+wewC5AWRwURgez+tC0F
hJkOdMkg2E8CCriaaL+OZbXQ4YJ+Xz2M95ICEfb5xg5xqznEXrHHCuHD2rEklkmO
D6bioHMaSQ==
=EfAj
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to