Your message dated Mon, 22 Dec 2014 18:19:50 +0000
with message-id <[email protected]>
and subject line Bug#773107: fixed in dbus 1.8.12-2
has caused the Debian Bug report #773107,
regarding dbus-daemon-launch-helper permissions temporarily wrong during 
upgrades
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
773107: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=773107
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: dbus
Version: 1.8.12-1
Severity: important

dbus-daemon-launch-helper is expected to be setuid root and executable
by group messagebus, i.e. "root messagebus 4754" in dpkg-statoverride syntax.
However, because messagebus is a dynamically-allocated system group,
the file in the .deb is actually "root root 0755", with ownership
and permissions fixed up during installation.

At the moment we just do a trivial chown/chmod in the postinst:

    if ! dpkg-statoverride --list "$LAUNCHER" >/dev/null 2>&1; then
            chown root:"$MESSAGEUSER" "$LAUNCHER"
            chmod 4754 "$LAUNCHER"
    fi

However, this is not as robust as it could be. When a new dbus has been
unpacked but not yet configured, dbus-daemon-launch-helper is
temporarily "root root 0755", breaking system service activation.

While upgrading a wheezy laptop to jessie, I hit one of the current dpkg
bugs with trigger cycles (man-db -> man-db) which stopped the upgrade
while dbus was in this state. An error message from PackageKit notification
demonstrated the bug:

dpkg: cycle found while processing triggers:
 chain of packages whose triggers are or may be responsible:
  man-db -> man-db
...
Error: GDBus.Error:org.freedesktop.DBus.Error.Spawn.PermissionsInvalid: The 
permission of the setuid helper is not correct
E: Sub-process /usr/bin/dpkg returned an error code (1)

I think we could make dbus more robust by following the pattern
suggested in Policy §10.9:

    # postinst
    if ! dpkg-statoverride --list "$LAUNCHER" >/dev/null 2>&1; then
        dpkg-statoverride --update --add root "$MESSAGEUSER" 4754 "$LAUNCHER"
    fi

    # postrm, $1 = purge
    if dpkg-statoverride --list "$LAUNCHER" >/dev/null 2>&1 ; then
        dpkg-statoverride --remove "$LAUNCHER"
    fi

This would not immediately help upgrades from current dbus versions to the
first version with this bug fixed, but all subsequent upgrades
(e.g. jessie -> stretch) would avoid the broken transitional state.

We could optionally also do something like this in preinst:

    # preinst
    if getent group "$MESSAGEUSER" >/dev/null && \
            -x "$LAUNCHER" && \
            ! dpkg-statoverride --list "$LAUNCHER" >/dev/null 2>&1; then
        dpkg-statoverride --update --add root "$MESSAGEUSER" 4754 "$LAUNCHER"
    fi

to improve the robustness of upgrades from current dbus versions to the
fixed version.

Regards,
    S

--- End Message ---
--- Begin Message ---
Source: dbus
Source-Version: 1.8.12-2

We believe that the bug you reported is fixed in the latest version of
dbus, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Simon McVittie <[email protected]> (supplier of updated dbus package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sun, 21 Dec 2014 15:02:22 +0000
Source: dbus
Binary: dbus dbus-udeb dbus-x11 libdbus-1-3 libdbus-1-3-udeb dbus-1-doc 
libdbus-1-dev dbus-1-dbg
Architecture: all source
Version: 1.8.12-2
Distribution: unstable
Urgency: medium
Maintainer: Utopia Maintenance Team 
<[email protected]>
Changed-By: Simon McVittie <[email protected]>
Closes: 773107
Description: 
 dbus-1-dbg - simple interprocess messaging system (debug symbols)
 dbus-1-doc - simple interprocess messaging system (documentation)
 dbus       - simple interprocess messaging system (daemon and utilities)
 dbus-udeb  - simple interprocess messaging system (minimal runtime) (udeb)
 dbus-x11   - simple interprocess messaging system (X11 deps)
 libdbus-1-3 - simple interprocess messaging system (library)
 libdbus-1-3-udeb - simple interprocess messaging system (minimal library) 
(udeb)
 libdbus-1-dev - simple interprocess messaging system (development headers)
Changes:
 dbus (1.8.12-2) unstable; urgency=medium
 .
   * postinst: use dpkg-statoverride to set the permissions for
     dbus-daemon-launch-helper (expected to be 04754 root:messagebus)
     as suggested in Policy §10.9. This avoids a temporarily broken state
     when an upgraded dbus is unpacked but not yet configured (Closes: #773107)
   * preinst: opportunistically set up the same dpkg-statoverride entry
     if the group already exists, to avoid the same broken state during
     upgrades from older versions without needing Pre-Depends: adduser
   * postrm: delete the dpkg-statoverride entry on purge
Checksums-Sha1: 
 888dc23f5ff6d40963e0660d5cc71b3350eaedb9 2785 dbus_1.8.12-2.dsc
 68b9e80bfb59af13d7b9756f58aec7c4f6f6a3d7 37472 dbus_1.8.12-2.debian.tar.xz
 1523c8077e6344ed9810c0be61f6ca0f02c4323e 1320972 dbus-1-doc_1.8.12-2_all.deb
Checksums-Sha256: 
 e9de1ee984a514c6c78040876d34088c3ef921d048d493cef9f3ad78457b3cb0 2785 
dbus_1.8.12-2.dsc
 06981336c78178fc5a3977c5561780ebe3b3d56dadbabf8d6857fb9f30f4a3a9 37472 
dbus_1.8.12-2.debian.tar.xz
 297d431249c8fc2988d846b426b4e103e916f4d49f70c76b9f7ab0b053208f00 1320972 
dbus-1-doc_1.8.12-2_all.deb
Files: 
 715cfde8d05c040b2b161bb992175427 2785 admin optional dbus_1.8.12-2.dsc
 cab1d0dc7dd3bdcb321ab725d39a0145 37472 admin optional 
dbus_1.8.12-2.debian.tar.xz
 303966859f9b0cfc8022222a399d8c97 1320972 doc optional 
dbus-1-doc_1.8.12-2_all.deb

-----BEGIN PGP SIGNATURE-----

iQIVAwUBVJhabU3o/ypjx8yQAQh2Xw/+ItnlxiWkYSKToHAAv5AeA2Yv6EgvpJ2n
E/xI09FJKiilHOwCXH0G49VRopisbaDyA6ClhJm+IwYF8JhRpcO+c9BNVzKcBguD
GRo6HUpdRY4J2yIUZskBxmGqX1/EwCwfxc224f2nlsVjWHbeGTC6iH77jAdZL+c2
Cv6xmhsUJ0BkdG8Bqn4vdqNEf7Oir+Pm0lJrsaR8yXcKWjC5EgornZE7NTOPsAx0
kz7rdTu8STVMF4zYqr7yvUks7JOAFOrIyZei5hqm7mBgc7YJNi5oDIDLhY99Somq
JJqbrLK3A4KUh5AOgSJdAYsAG4Ym1qWThT0mxpn0obQw1/+CorWEqzkmmavlMwyT
59e8+N2Nhk3OixarnmdDfD3Jvde/UQSFw8F+kZBj0GPDMj9a0jYrQYa8elm6YGXh
PRjdqsBfhZVEkIyVxPZylus9M6xt6tyNj7lMRO+SjZFk07n2o+ANHyQGMvOlO9DT
gsUOleixdB45QF3EMJfGVpJ+2yZd0Y1aWotqAnp4JHHC1auF2Hk6xrKumNTCqv+6
lCjRejPI3ygqrPK7PqMAlI8sDS96dQsYLX+faJlsmCrFVbuXgN0CcHSBCO2hyJse
ee6iXTwRRhOWB49rmXk5zpQb/Eo/ed/u+GvjmBxft8FjTLQvpLYl0kPVCxlFFENv
wCAITSQbVcs=
=4Xao
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to