Your message dated Tue, 23 Aug 2011 00:17:16 +0000
with message-id <e1qveg8-0008ac...@franck.debian.org>
and subject line Bug#628076: fixed in devscripts 2.11.1
has caused the Debian Bug report #628076,
regarding uscan: Fix --destdir regression when repacking ZIP files
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)
--
628076: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=628076
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: devscripts
Version: 2.10.73
Severity: normal
Tags: patch
User: devscri...@packages.debian.org
Usertags: uscan
Hi,
the fixes I sent for #615108 introduced a regression: the --destdir
option no longer works with relative paths. This is because we now cd
before calling tar, which breaks the relative path.
The attached patch remedies this by creating an absolute version of the
path for the tar-archiving command.
Regards,
Christian
From 8307bab639bd590b5fa7aa4ada5a5dbda311c808 Mon Sep 17 00:00:00 2001
From: Christian Kastner <deb...@kvr.at>
Date: Fri, 27 May 2011 00:21:18 +0200
Subject: [PATCH] Fix --destdir regression when repacking ZIP files
The --destdir option no longer worked with relative paths because we cd before
archiving. This patch uses an absolute path when creating the archive.
---
scripts/uscan.pl | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/scripts/uscan.pl b/scripts/uscan.pl
index d760281..c1599d3 100755
--- a/scripts/uscan.pl
+++ b/scripts/uscan.pl
@@ -24,6 +24,7 @@
use 5.008; # uses 'our' variables and filetest
use strict;
use Cwd;
+use Cwd 'abs_path';
use File::Basename;
use File::Copy;
use File::Temp qw/tempdir/;
@@ -1374,12 +1375,13 @@ EOF
my $tempdir = tempdir ( "uscanXXXX", TMPDIR => 1, CLEANUP => 1 );
my $globpattern = "*";
my $hidden = ".[!.]*";
+ my $absdestdir = abs_path($destdir);
system("unzip -q -a -d $tempdir $destdir/$newfile_base") == 0
or die("Repacking from zip to tar.gz failed (could not unzip)\n");
if (defined glob("$tempdir/$hidden")) {
$globpattern .= " $hidden";
}
- system("cd $tempdir; GZIP=-9 tar --owner=root --group=root --mode=a+rX -czf $destdir/$newfile_base_gz $globpattern") == 0
+ system("cd $tempdir; GZIP=-9 tar --owner=root --group=root --mode=a+rX -czf $absdestdir/$newfile_base_gz $globpattern") == 0
or die("Repacking from zip to tar.gz failed (could not create tarball)\n");
unlink "$destdir/$newfile_base";
$newfile_base = $newfile_base_gz;
--
1.7.5.1
signature.asc
Description: OpenPGP digital signature
--- End Message ---
--- Begin Message ---
Source: devscripts
Source-Version: 2.11.1
We believe that the bug you reported is fixed in the latest version of
devscripts, which is due to be installed in the Debian FTP archive:
devscripts_2.11.1.dsc
to main/d/devscripts/devscripts_2.11.1.dsc
devscripts_2.11.1.tar.gz
to main/d/devscripts/devscripts_2.11.1.tar.gz
devscripts_2.11.1_i386.deb
to main/d/devscripts/devscripts_2.11.1_i386.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 628...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
James Vega <james...@debian.org> (supplier of updated devscripts package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Mon, 22 Aug 2011 19:51:03 -0400
Source: devscripts
Binary: devscripts
Architecture: source i386
Version: 2.11.1
Distribution: unstable
Urgency: low
Maintainer: Devscripts Devel Team <pkg-devscri...@teams.debian.net>
Changed-By: James Vega <james...@debian.org>
Description:
devscripts - scripts to make the life of a Debian Package maintainer easier
Closes: 528274 625620 628076 628086 628447 628481 628674 630808
Changes:
devscripts (2.11.1) unstable; urgency=low
.
[ David Prévot ]
* Stylish manual pages convention review. (Closes: #628447)
* Handle the last description in devscripts(1). (Closes: #628086)
* French translation updates.
.
[ Adam D. Barratt ]
* debian/copyright: Update repository information somewhat belatedly
for the move to git.
.
[ James Vega ]
* debchange: Remove dapper from the list of recognized distributions.
* debcheckout: Handle Alioth's new anonymous access URLs when converting to
authenticated URLs. (Closes: #628674)
* debsnap: Allow -a to be specified multiple times. Thanks to Timo Juhani
Lindfors for the suggestion.
* uscan: Fix --destdir regression when repacking zip archives. Thanks to
Christian Kastner for the patch. (Closes: #628076)
* mergechanges: Do not drop fields when the Files/Checksums-* fields are not
at the end of the source files. (Closes: #625620)
* debuild: Call dpkg-source --before-build/--after-build when emulating
dpkg-buildpackage. (Closes: #628481)
* chdist:
+ Create /etc/apt/apt.conf.d and /etc/apt/preferences.d in the chdist
directory structure. (Closes: #528274, LP: #566682)
+ When multiple binary versions exist, use newest version for
compare-src-bin-*.
+ Copy archive keyrings to etc/apt/trusted.gpg.d.
.
[ Christoph Berg ]
* dscextract: new script, extracts a single file from a Debian source
package.
* debcheckout: When retrieving the source for debian/-only repositories,
move all .dsc components to the current directory, not just .orig.tar.gz.
* uscan: Catch perl warning with incorrect watch files without ().
Also, catch warnings on non-matches of ()? constructs.
.
[ Stefano Rivera ]
* Support //scheme-local URLs in hrefs, correctly (as used by Google code)
(Closes: #630808)
Checksums-Sha1:
acff3c725f6f618c58edcf231c36e6590163e1ea 1564 devscripts_2.11.1.dsc
fcfc9bda936aefb651c2c02c4cd9aac8d368cf7e 759565 devscripts_2.11.1.tar.gz
f87d9b156611e35a2f23c97e744ac3e4b487c724 695894 devscripts_2.11.1_i386.deb
Checksums-Sha256:
bb7fb6496d581480135a27061094ce7ced5ab0d6ec6fc6ff3e7664b61da8c5ef 1564
devscripts_2.11.1.dsc
7f3745c527cb99c15e233f465697b91b2bb85b4cc27d91257730e183b2da53f1 759565
devscripts_2.11.1.tar.gz
8f66896ccdccbb2c3f1817c03b9fddfca9d3f6f2b133955ffacf21274eb1ad22 695894
devscripts_2.11.1_i386.deb
Files:
e57409f68e02238d9c931c7cdc2f2b98 1564 devel optional devscripts_2.11.1.dsc
1b5da15d56104b0f2d289e536e3a05da 759565 devel optional devscripts_2.11.1.tar.gz
847bee5b6ff95aea7257b6709204b0fa 695894 devel optional
devscripts_2.11.1_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
iEYEARECAAYFAk5S7vkACgkQDb3UpmEybUBqkQCfaveWWB3WBmt4xApmmZkjWxiN
mZIAn1Fn542Nw5LqQtCvTOHGxDS+U0bO
=KSnx
-----END PGP SIGNATURE-----
--- End Message ---
