Lisandro Dalcin, 03.08.2012 18:51:
>> Stefan Behnel, 03.08.2012 06:04:
>>> Lisandro, could you open a pull request with only the single line change
>>> and a comment that properly explains why we are doing this?
> 
> Is the comment blow clear enough for you?

Thanks. I fixed it up a little. :)


> Stefan, I've never used github seriously, and making a pull request
> will require time I really do not have.

github is really cool here, you can basically edit a source file in place
and then send it in as a pull request.


> The patch is really trivial,
> any chance to push it directly?

https://github.com/cython/cython/commit/fd6380ab37d32ec67d5cc818c93b8d317f139e4d


> There is a policy is to use pull
> requests for every change (sorry, I've not been following Cython
> development closely)?

Sort-of. It makes it easy to see in the history who wrote a patch and who
applied it, usually after reviewing it. It's more meant to give proper
credit to people than to force them into bureaucratics, though.

Stefan

_______________________________________________
cython-devel mailing list
cython-devel@python.org
http://mail.python.org/mailman/listinfo/cython-devel

Reply via email to