On Mon, 2 Jan 2023 14:38:03 +0900
Takashi Yano wrote:
> On Mon, 2 Jan 2023 11:32:01 +0900
> Takashi Yano wrote:
> > On Sat, 31 Dec 2022 13:01:29 -0700
> > Brian Inglis wrote:
> > > was also getting the messages below locally and still on GitHub scallywag:
> > >
> > > cygcheck (6936) child_copy: cygheap read copy failed,
> > >
> > > ../curl/scallywag/1_x86_64 build.log:2022-12-26T00:39:35.6163236Z
> > > 0
> > > [main] cygcheck (6936) child_copy: cygheap read copy failed,
> > > 0x0..0x80003B5F0,
> > > done 0, windows pid 6936, Win32 error 299
> > > ../curl/scallywag/1_x86_64 build.log:2022-12-26T00:48:03.4525278Z
> > > 0
> > > [main] cygcheck (568) child_copy: cygheap read copy failed,
> > > 0x0..0x80003BA48,
> > > done 0, windows pid 568, Win32 error 299
> > > ../dialog/scallywag/1_x86_64 build.log:2022-12-31T18:42:37.0939902Z
> > > 0
> > > [main] cygcheck (6992) child_copy: cygheap read copy failed,
> > > 0x0..0x80003CB38,
> > > done 0, windows pid 6992, Win32 error 299
> >
> > I guess this is another problem.
>
> I found this issue occurs after the commit 30add3e6b3e3:
> "Cygwin: exec: don't access cygheap before it's initialized"
> .
>
> Reverting this commit solves the issue.
>
> To reproduce the problem relatively frequently, try:
> while true; do cygcheck -cd cygwin > /dev/null; done
> in bash.
>
> Corinna, could you please have a look at this issue as well?
I'm not sure if this is the right thing, but the following
patch seems to fix the issue.
diff --git a/winsup/cygwin/dcrt0.cc b/winsup/cygwin/dcrt0.cc
index 5c5a280cc..49b7a44ae 100644
--- a/winsup/cygwin/dcrt0.cc
+++ b/winsup/cygwin/dcrt0.cc
@@ -631,8 +631,6 @@ child_info_spawn::handle_spawn ()
if (!dynamically_loaded || get_parent_handle ())
{
cygheap_fixup_in_child (true);
- if (dynamically_loaded)
- moreinfo->myself_pinfo = NULL;
memory_init ();
}
diff --git a/winsup/cygwin/mm/cygheap.cc b/winsup/cygwin/mm/cygheap.cc
index 72861d8d7..6a20c159a 100644
--- a/winsup/cygwin/mm/cygheap.cc
+++ b/winsup/cygwin/mm/cygheap.cc
@@ -95,6 +95,8 @@ cygheap_fixup_in_child (bool execed)
cygheap = (init_cygheap *) VirtualAlloc ((LPVOID) CYGHEAP_STORAGE_LOW,
commit_size, MEM_COMMIT,
PAGE_READWRITE);
+ if (dynamically_loaded && execed)
+ spawn_info->moreinfo->myself_pinfo = NULL;
cygheap_max = child_proc_info->cygheap_max;
child_copy (child_proc_info->parent, false, child_proc_info->silentfail (),
"cygheap", cygheap, cygheap_max, NULL);
--
Takashi Yano <takashi.y...@nifty.ne.jp>
--
Problem reports: https://cygwin.com/problems.html
FAQ: https://cygwin.com/faq/
Documentation: https://cygwin.com/docs.html
Unsubscribe info: https://cygwin.com/ml/#unsubscribe-simple
