On Nov 1 17:58, Christian Franke wrote:
> Corinna Vinschen wrote:
> >I just released a 4th TEST version of the next upcoming Cygwin release,
> >1.7.33-0.4.
>
> There is an older regression in mkgroup.
> A separator without a preceding domain name is printed for the builtin
> groups:
>
> $ mkgroup -L THISHOST
> SYSTEM:S-1-5-18:18:
> TrustedInstaller:S-1-5-80-...
> +Administratoren:S-1-5-32-544:544:
> +Benutzer:S-1-5-32-545:545:
> ...
> THISHOST+HelpLibraryUpdaters:S-1-5-21-...
>
>
> Introduced in mkgroup.c CVS 1.54, April 2014:
>
> @@ -415,8 +341,8 @@ enum_local_groups (...)
> ...
> printf ("%ls%s%ls:%s:%" PRIu32 ":\n",
> - with_dom && !is_builtin ? domain_name : L"",
> - with_dom && !is_builtin ? sep : "",
> + mach->with_dom && !is_builtin ? domain_name : L"",
> + mach->with_dom || is_builtin ? sep : "", <==== Hmm.... :-)Thanks! It would be nice if you could send a patch to cygwin-patches. > BTW: mkgroup should possibly also print the extra builtin groups which are > now reported by getgroups(), for example 4(Interactive), 11(Authenticated > Users), ... Doesn't make much sense. Generating them via "db" is incredibly fast. There is also one person on the list (sorry, don't remember your name) claiming he would rather not see the big group list in id while using the "files"-only setting. Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat
pgpdUhfBLRsiY.pgp
Description: PGP signature
