...but that doesn't handle UNC paths. It might be worth looking at how Chromium does this:
https://github.com/scheib/chromium/blob/master/url/url_parse_file.cc On Tue, Aug 5, 2014 at 1:21 PM, James Nylen <jny...@gmail.com> wrote: > Chrome and IE cope with these variants just fine: > > file:C:/Projects > file:/C:/Projects > file://C:/Projects > file:///C:/Projects > file:////C:/Projects > > IE doesn't like more than 4 slashes, but Chrome doesn't mind. > > Your patch appears to only cover 0 or 2 slashes. How about something > like this instead of checking for "//": > > // remove all slashes except the last one > while (strncmp(aPath, "//", 2) == 0) aPath++; > > // path /C:/Projects is invalid, want C:/Projects instead > if (*aPath == '/' && *(aPath + 2) == ':') aPath++; > > On Tue, Aug 5, 2014 at 1:02 PM, Juan Gabriel Ricart > <juangabriel.ric...@gmail.com> wrote: >> Greetings, >> >> Below you may find a trivial patch for the cygstart program (a part of >> the cygutils package) for your review: >> >> --- cygstart.c.old 2014-08-05 15:37:49.021062800 +0000 >> +++ cygstart.c.new 2014-08-05 14:20:54.318820400 +0000 >> @@ -591,8 +591,12 @@ >> const wchar_t *pWinDir = NULL; >> int rc = 0; >> >> - if (strncmp (aPath, "file://", 7) == 0) >> - aPath += 7; >> + if (strncmp (aPath, "file:", 5) == 0) >> + { >> + aPath += 5; >> + if (strncmp (aPath, "//", 2) == 0) >> + aPath += 2; >> + } >> #ifdef __CYGWIN__ >> /* Convert file path from POSIX to Windows, unless it looks like a URL */ >> if (!strstr (aPath, "://") && strncmp (aPath, "mailto:";, 7) != 0) >> >> It makes the double slash after the scheme optional for file URIs. So >> this error would not happen: >> >> $ cygstart file:/home/ricartj/page.htm >> Unable to start 'file:\home\ricartj\page.htm: The specified file was not >> found. >> >> The reasons for this are enumerated below: >> >> 1. Although RFC 1738 explicitly documents the double slash as >> mandatory for file URIs (see Section 5), a new working draft is being >> proposed: >> >> http://tools.ietf.org/html/draft-kerwin-file-scheme-10 >> >> which makes the double slash optional (see Section 2.2). >> >> 2. Many browsers already cope with file URIs that do not contain the >> double slash, I personally tested this with Firefox and Internet >> Explorer. It would be great if cygstart could work like this as well. >> >> Best regards, >> >> -- >> Juan Ricart >> >> -- >> Problem reports: http://cygwin.com/problems.html >> FAQ: http://cygwin.com/faq/ >> Documentation: http://cygwin.com/docs.html >> Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple >> -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple
