On 2025-09-21 10:28, Jon Turney via Cygwin-apps wrote:
On 08/09/2025 16:04, Carlo B. via Cygwin-apps wrote:
Hello,
I tried to make a CYGWIN package for moserial, a GTK-based serial terminal
Unfortunately, when starting to build, it stopped with this error:
/usr/share/cygport/cygclass/autotools.cygclass: line 334: intltoolize:
comand not found
intltoolize is used here:
https://github.com/cygwin/cygport/
blob/8f58ef724b523fc7ec261c79053ed90c93b443ab/cygclass/autotools.cygclass#L334
Since intltoolize is used directly by a class of cygport, perhaps it
would be worth to also add intltool to the dependecies listed into
data/sample.cygport:
I'm not sure.
On the one hand, obviously yes.
On the other hand: installing cygport already pulls in a lot 'build-essential'-
type stuff. Does it make sense for it to pull in all the build tools for every
metaproject it supports?
Especially in cases like this, where the error message is relatively clear about
the problem, and the solution (hopefully) not too obscure, maybe we don't need
to handhold?
++ otherwise cygport would not need b-r, and they are not always obvious
(Orthogonal to this, there's probably some scope for certain inherits to
automatically add to BUILD_REQUIRES. At the moment, there's some logic for this
which lives in scallywag [1], but this probably belongs in cygport proper - so
that e.g. 'inherit gnome' will get you a warning about required packages not
being installed if 'gnome-common' is missing etc.)
++ would be nice if package maintainers could add checks and additions to b-r in
their PKG.cygclass, using mainly check_prog_req and check_pkg_config, other
functions in check_funcs.cygpart, perhaps new `check_depend ATOM` broken out
from __check_depends(), and `add_build_requires PKG` or similar?
[1] https://cygwin.com/cgit/cygwin-apps/scallywag/tree/analyze.py#n274
- delegate the "done properly" work to the cygclass?
I would be okay with just checking and warning about required dependencies, as
long as it is done in the prep step or earlier, because some packages can take
an hour or more to build, and/or an hour or more to check, and having them fail
due to a missing install, especially in CI, is annoying! ;^>
I tend to name all the documented package dependencies in b-r as that avoids any
need to check what cygport depends on this release.
It would be nice if all package upstream sources dropped their assumptions and
documented everything their builds require, rather than only whatever their
normal Linux desktop devel distro install does not include.
--
Take care. Thanks, Brian Inglis Calgary, Alberta, Canada
La perfection est atteinte Perfection is achieved
non pas lorsqu'il n'y a plus rien à ajouter not when there is no more to add
mais lorsqu'il n'y a plus rien à retrancher but when there is no more to cut
-- Antoine de Saint-Exupéry
