On 07/12/2024 16:26, Libor Ukropec via Cygwin-apps wrote:
Hello, I'd like to maintain the package "byobu", which is available also on several Linux distributions, e.g. on Ubuntu.
Thanks. I added this to your packages. [...]
Please review: BUILD_REQUIRES="gcc-g++"
During a brief look, I don't see the configure checking for a compiler? And it doesn't look like any .exe files are installed.
So is this really needed? Or should it be dropped and the package marked with ARCH="noarch", if all it installs are shell scripts?
PATCH_URI=" byobu-6.12-1.src.patch "
Huh, so the rules for patch names which are automatically applied are obscure, but are now documented at [1].
So this name doesn't need to be listed here, as it's automatically applied if present, for historical reasons.
(You'll see during the output of 'cygport prep' it tries to apply this twice, ignoring it as "already applied" the second time)
I'd suggest you rename this patch to give it a name which describes what it's fixing/doing.
[1] https://cygwin.github.io/cygport/src_fetch_cygpart.html#PATCH_URI
