Hi Jon, Thanks for reviewing.
On Sat, 13 Jan 2024 16:06:45 +0000 Jon Turney wrote: > On 07/01/2024 10:42, Takashi Yano via Cygwin-apps wrote: > > SVT-AV1 is video encoder/decoder for av1, which has > > very fast encoder compared with aom. Fedora has this > > package.https://src.fedoraproject.org/rpms/svt-av1 > > > > I would like to enable svt-av1 encoding in ffmpeg via > > this package. > > > > Thanks in advance. > > > > > > svt-av1.cygport > > > > NAME="svt-av1" > > VERSION=1.8.0 > > RELEASE=1 > > LICENSE="BSD-3-Clause" > > CATEGORY="Video" > > SUMMARY="Scalable Video Technology for AV1 (Encoer and Decoder)" > > Typo: "Encoder" Oops! > > --- origsrc/SVT-AV1-v1.8.0/Source/App/EncApp/EbAppConfig.h 2023-12-14 > > 21:33:03.000000000 +0900 > > +++ src/SVT-AV1-v1.8.0/Source/App/EncApp/EbAppConfig.h 2023-12-29 > > 18:52:22.639768700 +0900 > > @@ -52,9 +52,9 @@ typedef enum EncPass { > > #define MAX_NUM_TOKENS 210 > > > > #ifdef _WIN32 > > -#define FOPEN(f, s, m) fopen_s(&f, s, m) > > +#define SVT_FOPEN(f, s, m) fopen_s(&f, s, m) > > #else > > -#define FOPEN(f, s, m) f = fopen(s, m) > > +#define SVT_FOPEN(f, s, m) f = fopen(s, m) > > This provokes my curiosity. Is there some reason for renaming this macro? > > (In general, feel free to provide commentary at the start of the patch > file on why it's doing what it's doing :)) This is because FOPEN macro conflicts with the same name macro in cygwin's /usr/include/sys/_default_fcntl.h. I'll add comment. Thanks! -- Takashi Yano <takashi.y...@nifty.ne.jp>
