On 26/10/2023 16:56, Brian Inglis via Cygwin-apps wrote:
Hi folks,I have built an updated release of libvpx with the CVE fixes included.This is a Google WebM project which does not use autotools or libtool, so the last maintainer did their own cygvpx dll build and relinked the executables.
Taking a brief look over the cygport, if you're going to abstract out the soversion, you can use 'declare' to evaluate variable names
e.g.
ABI=8
PKG_NAMES="... libvpx${ABI} ..."
declare libvpx${ABI}_SUMMARY="$SUMMARY (runtime)"
declare libvpx${ABI}_CONTENTS="usr/bin/cygvpx-${ABI}.dll"
The current test programs do not relink against the unstripped dll, possibly because of their sizes requiring > 32 bit offsets, so I am no longer relinking the test programs with the dll, only the distributed utilities.$ du libvpx-1.13.1-1.x86_64/{build,inst/usr/bin}/*.{dll,exe} 23M libvpx-1.13.1-1.x86_64/build/cygvpx-8.dll 26M libvpx-1.13.1-1.x86_64/build/test_intra_pred_speed.exe 158M libvpx-1.13.1-1.x86_64/build/test_libvpx.exe 33M libvpx-1.13.1-1.x86_64/build/test_rc_interface.exe 3.3M libvpx-1.13.1-1.x86_64/build/vpxdec.exe 3.5M libvpx-1.13.1-1.x86_64/build/vpxenc.exe 3.4M libvpx-1.13.1-1.x86_64/inst/usr/bin/cygvpx-8.dll 680K libvpx-1.13.1-1.x86_64/inst/usr/bin/vpxdec.exe 700K libvpx-1.13.1-1.x86_64/inst/usr/bin/vpxenc.exeWith codec performance tests disabled, this build also downloads 1.4GB of test data files from Google under:https://storage.googleapis.com/downloads.webmproject.org/test_data/libvpx/which we presumably would prefer not to include in the src package, to
Yeah, including it seems a bad idea.
run tests which take 2.75-3.5 hours out of a 3.75-4.5 hour build, with 5 failures in scallywag CI and 2 failures locally out of 1596 tests, shown in the attached log, so I have questions into the upstream WebM libvpx project about those.Full scallywag logs are available at: https://cygwin.com/cgi-bin2/jobs.cgi?id=7148&srcpkg=libvpx&user=Brian+Inglis
Thanks. I've added this to your packages.
