src_test is not redefined in cmake.cygclass (and ninja.cygclass) in cygport-0.36.3. Therefore, I defined src_test in json-c.cygport.
- https://github.com/cygwin/cygport/blob/0.36.6/cygclass/cmake.cygclass - https://github.com/cygwin/cygport/blob/0.36.6/cygclass/ninja.cygclass I agree that it would be preferable to have src_test defined in one of these cygclasses. On Sun, Oct 1, 2023 at 11:43 PM Jon Turney <jon.tur...@dronecode.org.uk> wrote: > > On 24/09/2023 13:40, Daisuke Fujimura via Cygwin-apps wrote: > > Hi, > > > > I previously reported that json-c.pc seems incorrect. > > - https://cygwin.com/pipermail/cygwin/2023-August/254350.html > > > > The modified version of json-c.cygport and its CI results are shown below. > > - cygport > > - > > https://cygwin.com/cgit/cygwin-packages/playground/commit/?id=42b2343c88e9ba85dd689579335a77776691bb27 > > - CI > > - https://github.com/cygwin/scallywag/actions/runs/6286740463 > > > > Patch is also attached. > > Thanks. > > Since Marco isn't available at the moment, I did an NMU with this change. > > > - PATH=${B}:${PATH} ctest > > + PATH=${B}:${PATH} ninja_test > > Not sure if this part is needed. > > But it seems like it indicates a missing piece in cygport. Perhaps there > should be a src_test() defined by the cmake.cygclass which does > ninja_test or ctest depending on the generator? >
