On 19.05.2021 18:32, Jason Pyeron wrote:
-----Original Message-----
From: Marco Atzeri
Sent: Wednesday, May 19, 2021 3:06 AM
On 19.05.2021 07:16, ASSI wrote:
Jason Pyeron writes:
cygport $p finish prep compile inst test pkg
So for the pdfgrep that I am going to maintain, is it acceptable that I want
the package to not happen until I address the test failure? Like so?
you are the maintainer, it is your decision.
We just give you our opinion based on our experience
...
BUILD_REQUIRES="asciidoc gcc-g++ libpoppler-cpp-devel libgcrypt-devel libpcre-devel
dejagnu texlive-collection-latex docbook-xml45"
src_test() {
cd ${B}
make check
}
This is the default.
in general a generic test failure is not a valid reason to NOT package.
Most of my packages have peculiar test failures that can be just ignored
In several, I just use "cygmake -i check" in src_test
to avoid premature stop of the tests.
Others requires to be installed before the testsuite is
properly executed.
Since it is not required to be installed, I would like to lean towards stopping
to fix first.
The 1.4.1 seems fine. Or I am missing something ?
v/r,
Jason
Regards
Marco
