On 2017-07-05 08:27, Corinna Vinschen wrote: > On Jul 5 13:32, Nellis, Kenneth wrote: >> Curious about an error that setup.exe reported today related to upgrading >> package cygwin-doc to 2.8.1-1, saying: >> >> Postinstall script errors >> These do not necessarily mean that affected packages will fail to >> function >> properly, but please check /var/log/setup.log.full and report any >> problems. >> >> Package: _/cygwin-doc >> cygwin-doc.sh exit code 2 >> >> A subsequent setup.exe run with nothing pending gave a different message: >> >> Package: _/Unknown package >> cygwin-doc.sh exit code 2 >> >> Looking in setup.log.full I see: >> >> 2017/07/05 09:13:33 running: C:\cygwin64\bin\bash.exe --norc --noprofile >> "/etc/postinstall/cygwin-doc.sh" >> Can't find directory '/proc/cygdrive/c/ProgramData/Microsoft/Windows/Start >> Menu/Programs/Cygwin' >> 2017/07/05 09:13:34 abnormal exit: exit code=2 >> >> Indeed, there is no Cygwin directory in existing directory >> '/proc/cygdrive/c/ProgramData/Microsoft/Windows/Start Menu/Programs'. >> >> Looking at cygwin-doc.sh, it seems that the script is trying to put some >> things in that directory. >> >> So, I manually created the directory and reran setup. This time no errors >> reported, >> and the newly created directory contains the following files: >> >> $ ls -l >> total 24 >> -rwxr-xr-x+ 1 knellis Domain Users 1233 Jul 5 09:30 'API (HTML).lnk' >> -rwxr-xr-x+ 1 knellis Domain Users 1041 Jul 5 09:30 'API (PDF).lnk' >> -rwxr-xr-x+ 1 knellis Domain Users 1248 Jul 5 09:30 FAQ.lnk >> -rwxr-xr-x+ 1 knellis Domain Users 1224 Jul 5 09:30 'Home Page.lnk' >> -rwxr-xr-x+ 1 knellis Domain Users 1242 Jul 5 09:30 'User Guide (HTML).lnk' >> -rwxr-xr-x+ 1 knellis Domain Users 1050 Jul 5 09:30 'User Guide (PDF).lnk' >> $ >> >> So, these are handy links to have, I guess, but is it appropriate for >> cygwin-doc.sh to presume that the directory exists? Maybe it should create it >> rather than simply bail out and complain if it doesn't exist. > > In theory, the script should only create the files if the directory > exists. Brian?
Okay - assumed the directory would always be created by setup - presumably not true - but do not check that assumption in pi, although thought about it - should I check and skip creating shortcuts, rather than create dir and shorcuts? Should I also check and skip rm in prerm? And provide patches? -- Take care. Thanks, Brian Inglis, Calgary, Alberta, Canada
