2016-06-06 12:08 GMT+02:00 Marco Atzeri:
> builds and packages fine, but I suggest you
>
> 1) to add
>
> DIFF_EXCLUDES="VERSION"
>
> to avoid the useless creation of libsass-3.3.6-1.src.patch
Actually the patch isn't useless. It creates a VERSION file which
version.sh expects to exist during the building process. Without that
file, the library reports version "[na]" instead of the correct 3.3.6.
> 2) to move "usr/share/doc" from "libsass0" to "libsass-devel"
I've moved it to -devel, so they cygport file now reads:
---------------------------------------
# libsass
libsass0_SUMMARY="${SUMMARY} (runtime)"
libsass0_DESCRIPTION="${DESCRIPTION}"
libsass0_CATEGORY="Libs"
libsass0_CONTENTS="usr/bin/"
# libsass-devel
libsass_devel_SUMMARY="${SUMMARY} (development)"
libsass_devel_DESCRIPTION="${DESCRIPTION}"
libsass_devel_CATEGORY="Libs Devel"
libsass_devel_CONTENTS="usr/include/ usr/lib/ usr/share/doc/"
---------------------------------------
The updated package is available here: http://mural.uv.es/videlsol/libsass/
> I assume you tested it as per
> https://github.com/sass/sass-spec
Regarding tests, to be honest, I had not run any before. I tried
compiling a few Sass using sassc from Bootstrap v4 and it all went
fine, so I assumed it was working as expected. I've just now run them,
and there are nine parsing errors (out of around five thousands
asserts). The execution and the errors and can be seen here:
http://pastebin.com/yTcpK3Pj
They are probably nothing to worry about: the libsass library is for
the 3.3.x version of the specification, while the spec repository only
has tests for 3.4 onwards. I suppose the failing tests are caused by
newer features not available in the 3.3.x specification.
Regards,
--
Marcos Vives Del Sol
https://github.com/socram8888
miniLock: NscWdW8fh2E5SBoRtrnXWrDwmQmwaR5awMKE78tQW1Ffx
