Hi Mark, On Nov 15 22:02, Mark Geisert wrote: > I think my ITA is sorted out well enough to be reviewed. If you find a > sharp edge somewhere, please don't assume it's maintainer preference; it's > more likely maintainer ignorance so please do fill me in. > -------- > http://maxrnd.com/~mark/cygwin/cygutils/cygutils-1.4.15-1.src.patch > > http://maxrnd.com/~mark/cygwin/cygutils/cygutils.cygport > > http://maxrnd.com/~mark/cygwin/cygutils/cygwin-cygutils-1.4.15.tar.bz2 > -------- > [...]
Packaging looks good. Just one nit: While this is as Chuck did it way back when, I think the files under /usr/share/doc should go into the base cygutils package, rather than the cygutils-extra package, i.e. usr/share/doc/cygutils/AUTHORS usr/share/doc/cygutils/ChangeLog usr/share/doc/cygutils/COPYING usr/share/doc/cygutils/HOW-TO-CONTRIBUTE usr/share/doc/cygutils/licenses/ usr/share/doc/cygutils/licenses/COPYING.BSD-no-advert usr/share/doc/cygutils/licenses/COPYING.GPLv2 usr/share/doc/cygutils/licenses/COPYING.GPLv3 usr/share/doc/cygutils/NEWS usr/share/doc/cygutils/PROGLIST usr/share/doc/cygutils/README usr/share/doc/cygutils/TODO should be in the cygutils package, while usr/share/doc/cygutils/cygicons/ usr/share/doc/cygutils/cygicons/README usr/share/doc/cygutils/lpr/ usr/share/doc/cygutils/lpr/README should stay in cygutils-extra. That's a minor point and at your discretion, otherwise GTG. > -------- > Something I don't understand yet is why, when using this cygutils.cygport, > some cygport commands download the source from sourceware via git, while > other commands seem to want the .tar.bz2 file. The cygutils.cygport is > possibly not completely right yet. You have both, a SRC_URI and a GIT_URI. This might confuse cygport. Drop the SRC_URI and only keep GIT_URI. Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat
pgp7Pg3FAF31G.pgp
Description: PGP signature
