On 17/04/2013 19:59, Yaakov (Cygwin/X) wrote:
> On 2013-04-11 07:32, Dave Korn wrote:
>> On 11/04/2013 07:58, Yaakov (Cygwin/X) wrote:
>>> Your boehm-gc patch can replace my java-libgc-win32.patch, provided it
>>> works properly.
>>
>> It appears to, libjava testsuite results are as good as they've
>> ever been,
>> although I don't know whether or not the testsuite checks the
>> invocation API.
>> It's certainly the more complete approach to take than just not
>> supporting
>> the register/unregister methods, as confirmed by the fact that upstream
>> boehm-gc has implemented it for Cygwin.
>
> There is a mistake in that patch. The DEBUG_CYGWIN_THREADS conditionals
> need to be "if", not "ifdef", as elsewhere in the same source file.
Oops, that was a cut'n'paste error when I copied the skeleton of those
functions from pthread_support.c, where #ifdef DEBUG_THREADS is the form to
use. Thanks for spotting it; fixed in my repo ready for next release.
cheers,
DaveK
