On Sun, Aug 12, 2012 at 07:58:10PM +0200, Pawel Jasinski wrote: >On Sun, Aug 12, 2012 at 6:31 PM, Christopher Faylor wrote: >> On Sun, Aug 12, 2012 at 03:48:16PM +0200, Pawel Jasinski wrote: >>>sorry for the cross post. I just realized setup.exe should be >>>discussed here and not in main cygwin mailing list >>> >>>I have created patch for setup.exe to make it work with cntlm proxy. >>>Upon investigation I have discovered that, setup.exe does not handle >>>well the situation when connection is not closed at the end of each >>>individual file (Keep-Alive) and gets stuck. >>>If the HTTP response from proxy contains Content-Length, patched >>>version uses provided length to detect end of file condition. >>> >>>What are the chances to include it in official setup.exe release? >> >> Nonexistent as it stands right now. >> >> Your submission lacks a ChangeLog and, more importantly, comments. I >> have no idea why you're making the changes that you've made. You're >> changing code that has worked for years so we really need some >> justification for why what you've done is necessary. > >never mind, somehow I assumed setup.exe is using HTTP 1.1. I am wrong, >setup is using HTTP 1.0 >cntlm does not implement HTTP 1.0 correctly. >Given your comment, I assume you have no interest to switch to HTTP 1.1 > >thanks for the prompt response
You are somehow misreading my comment. I didn't mention "HTTP anything" and I don't see any occurrence of 1.1 in the patch. If you have a patch which changes setup.exe to use HTTP 1.1 we could consider it but all of my previous comments still apply. cgf
