On Jul 2 01:14, Charles Wilson wrote:
> On 6/29/2011 11:36 AM, Corinna Vinschen wrote:
> > here's a patch which adds a new functionality to rebase.
>
> I think this is a good idea; it's been on the rebase TODO list for some
> time. I share cgf's concern about dlls which change their ImageSize,
> but I haven't had a chance to go thru the patch -- it's a holiday
> weekend here in the US, and I've got Real Life stuff going on.
>
> I'll take a look next week.
Thanks. The answer to your concern is "yes, the code tests that".
If you have a look into the code next week, you'll be probably
very happy to see that I added lots of comments to explain what I'm
doing :)
Btw., there's one comment in the patch which is accidentally at the
wrong spot:
/* FIXME: This loop only implements the top-down case. Implement a
bottom-up case, too, at one point. */
The new merge_image_info function basically consists of three loops.
I put the comment in front of the second loop, but it belongs in front
of loop 3. I changed that locally, but it's not worth to send a new
patch for this, I think.
Corinna
--
Corinna Vinschen Please, send mails regarding Cygwin to
Cygwin Project Co-Leader cygwin AT cygwin DOT com
Red Hat
