-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Igor Peshansky wrote: > Hi, > > The current format for installed.db is (except the first line) > > PKG-NAME TARBALL-NAME 0 > > which setup tries to parse as > > package-name filename filesize src-filename srcsize > > (with src-filename and srcsize never used, and the filesize field never > accessed). I propose to remove the unused fields, with the intention of > later reusing the (always 0) for something else. > > The attached patch fixes the parsing of installed.db package lines. > Comments welcome. > Igor > ============================================================================== > ChangeLog: > 2006-01-22 Igor Peshansky <[EMAIL PROTECTED]> > > * cygpackage.h (filesize): Remove unused field. > (cygpackage::createInstance): Ditto. > * cygpackage.cc (cygpackage::createInstance): Ditto. > * package_db.cc (packagedb::packagedb): Remove unused variables. > Simplify parsing of installed.db.
Does this constitute dropping support for "version 1" installed.db files? If so, we should remove the rest of the code attempting to support version 1 too. Max. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2.1 (Cygwin) iD8DBQFEGZNTfFNSmcDyxYARAk8bAKCnAlKrm+rj+C4KmUOutVWClRynewCcDdaK BzQYQgMFWjTY2y4Fh+q8L8Y= =Aw2M -----END PGP SIGNATURE-----