On Thu, 16 Feb 2006, Lapo Luchini wrote:
> Igor Peshansky wrote:
> > Umm, now I'm confused. There is nothing in the setup source that
> > would explain this behavior. Which version of setup are you using?
> > Which OS is this happening on? We *are* talking about the
> > "-r"/"--no-replaceonreboot" option, right?
>
> As I hate rebooting unless strictly necessary I always use "-rNd", yes.
> As of the version.. well, I got that behaviour from the very beginning,
> when I was told of -r in the first place. I don't quote remember when,
> but at least one year ago (searching this mailing list I could probably
> find the exact day, tell me if you need it) and up to today. I'm using
> WinXP x64 now, but it was just the same on the good old plain WinXP I
> used until august.
Eek. This is a bug that became a feature, apparently. I just reproduced
this behavior. Basically, what I didn't realize was that the archive_tar
class wouldn't even try extracting a file if it wasn't able to open the
destination for writing, keeping the archive cursor the same, so the
next_file_name() call will keep returning the same file over and over.
Don't know if this behavior is intentional (doesn't look like it, based on
the error tracking in the rest of the code -- I think it was expected to
fail and go on to the next file). Brian, any comments on this? Should
this be fixed (after my patch goes in effect, that is, so that people who
rely on this behavior have an alternative)?
> BTW: do -N and -d /really/ need to warn me with a modal windows each
> time? if I went to the extent to add them I guess I do know I do not
> want those installed, quietly avoiding that would be the expected
> behaviour...
This is a leftover debugging MessageBox for '-N', apparently. You can use
'-n'/'--no-shortcuts' as a workaround for this (it's supposed to have the
same effect as '-Nd', and does, with an added benefit of skipping the
MessageBox code). This should be fixed (with a patch below).
> moreover in latest setup release those modal windows sometimes appear
> /under/ the main windows and are closable only with a combination of
> "alt-tab" and "enter", and must be killed altogether if using setup thru
> VNC
The '-n' option should solve this for you until the below patch is
applied.
Igor
2006-02-16 Igor Peshansky <[EMAIL PROTECTED]>
* desktop.cc (DesktopSetupPage::OnInit): Remove stray MessageBox.
Index: desktop.cc
===================================================================
RCS file: /cvs/cygwin-apps/setup/desktop.cc,v
retrieving revision 2.41
diff -u -p -r2.41 desktop.cc
--- desktop.cc 5 May 2005 22:48:34 -0000 2.41
+++ desktop.cc 16 Feb 2006 15:01:08 -0000
@@ -355,7 +355,6 @@ DesktopSetupPage::OnInit ()
if (NoStartMenuOption)
{
root_menu = 0;
- MessageBox(NULL, "NoStartMenuOption", "NoStartMenuOption", MB_OK);
}
else
{
--
http://cs.nyu.edu/~pechtcha/
|\ _,,,---,,_ [EMAIL PROTECTED] | [EMAIL PROTECTED]
ZZZzz /,`.-'`' -. ;-;;,_ Igor Peshansky, Ph.D. (name changed!)
|,4- ) )-,_. ,\ ( `'-' old name: Igor Pechtchanski
'---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow!
"Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte."
"But no -- you are no fool; you call yourself a fool, there's proof enough in
that!" -- Rostand, "Cyrano de Bergerac"
