-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Yaakov S (Cygwin Ports) wrote:
> OK, I have it built; but test results are sporadic (they vary each
> time I run the tests).
I needed this patch in order to have it working on FAT32 disks, but
both on FAT and NTFS the test results seem quite consistent to me: all
is good on NTFS and all-but-test-9 on FAT.
Test 9 checks if a directory mtime gets modified when you write a file
in it and I guess FAT just doesn't work that way.
What did you mean exactly with "vary each time"?
- --- gamin-0.1.5-orig/libgamin/gam_api.c 2005-08-06 00:31:46.000000000
+0200
+++ gamin-0.1.5/libgamin/gam_api.c 2006-01-30 13:17:14.000000000
+0100
@@ -228,12 +229,15 @@
dir);
goto unsafe;
}
+#ifndef __CYGWIN__
+ // this can't work on FAT disks, that have no permissions
if (st.st_mode & (S_IRWXG|S_IRWXO)) {
gam_error(DEBUG_INFO,
"Socket directory %s has wrong permissions\n",
dir);
goto unsafe;
}
+#endif
if (((st.st_mode & (S_IRWXU)) != S_IRWXU)) {
gam_error(DEBUG_INFO,
"Socket directory %s has wrong permissions\n",
@@ -307,12 +311,15 @@
goto cleanup;
}
#endif
+#ifndef __CYGWIN__
+ // this can't work on FAT disks, that have no permissions
if (st.st_mode & (S_IRWXG|S_IRWXO)) {
gam_error(DEBUG_INFO,
"Socket %s has wrong permissions\n",
path);
goto cleanup;
}
+#endif
/*
* Looks good though binding may fail due to an existing server
*/
Reading that file, me and Alex have a doubt: is it normal that only 2
out of 3 times defined(__FreeBSD__) is added in the FreeBSD patch set
you added a corresponding defined(__CYGWIN__)?
I don't quite get that part, so I guess that you did either the right
thing or did forget about the last case ;-)
About possibly implementing an NT backend (using
http://tinyurl.com/c27fn probably), well, I guess it is feasible but
with 1300+ lines of code for all but the simplest backend (dnotify)
we're a bit scared about that, and moreover efficiency is not a really
big issue in our case.
"Not in the short time period", that's for sure.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (FreeBSD)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iQIcBAEBAgAGBQJD3iRJAAoJEJLw0EUVBG94d18QAKugLtFSL51ExnjXNW39hpHY
PSJ6HvJxpQDDe9/Cx0JHIrvADvgWGS3Yfl19N4p1Vq/pYTWbuh4DgXyHhQyCik+W
biawt3ocFk7xRzcy/1hRt5KqXPYhY5EspuZTekv9qTVh59rTb/MWkSGCAIAsadxO
vbnyLP13yergGLgmrHeDoR2UIqOqL2BpVsjfMsWhsQxyPiZNMRoD0ggt2/AsvKQg
OJ3exomeN93OweNw11ETZazz/HzZVCgslNz2kPbgy8JpZDphA22XLFieijDJdQwg
bixfhsEBLiN8qQDhQi5b9wh3EsnfDSRoo1OW2FoO0hAOHHemOcTc1/nC2jP5hMUe
Xzj+BXAVz01BrvrsRqcQ7tcjcAV5tXLZum8FdxnBGcWONcpq+7UnbcvOC9svvTMA
h4adUv577R5ciE6xwNcMsISjk+aHoV3oAliYe9RCnH7Lx9fKV7EC4SZFDbOCwMkd
erqkpJMwGRfksjTLBncX9ctazo0WPi0GeyU0sO7BkRb75Gq2fE84X5+Ny+kbhihW
TzSKbphJhCzFoyM1QG/sRa/dMN3X0rqjeoiPsq2MZIG39zMy8N9b95xIn8tb2yMI
6wcE6i////PC8mzxJBqRc/aXnx3dFhlZrVjIrnhYAhwiVvznwSZQUNq+wNVb9taE
5v5LUSzA6zijAAvi7nbW
=mC7m
-----END PGP SIGNATURE-----
