On Tue, 21 Jun 2005, Max Bowsher wrote:
> Two generic build script patches.
>
> Number 1:
> In doing the httpd->apache2 thing recently mentioned, I found that g-b-s
> could use some tweaks to support this better. ${BASEPKG} is currently
> used by the script in two different ways:
> 1): name-version of the base upstream package
> 2): name-version of the cygwin package
> Of course, normally these are the same, but in my case they are not.
> Therefore, the following patch changes all occurrences where ${BASEPKG}
> is used in the second sense to ${PKG}-${VER}, so that ${BASEPKG} may be
> redefined in my case.
>
> [patch snipped]
>
> Number 2:
> Use "xargs --no-run-if-empty". I don't recall for what package I needed
> this, but I've had it locally for some time. In any case, it is good
> bulletproofing.
>
> [patch snipped]
The first patch looks good. I was about to apply it, but realized that
it's missing a ChangeLog entry. Care to post one?
About the second patch: I usually prefer to use the short option ("-r").
There were a few other places that didn't use it. I've made the
appropriate modifications and committed the change.
Thanks for the patches,
Igor
--
http://cs.nyu.edu/~pechtcha/
|\ _,,,---,,_ [EMAIL PROTECTED]
ZZZzz /,`.-'`' -. ;-;;,_ [EMAIL PROTECTED]
|,4- ) )-,_. ,\ ( `'-' Igor Pechtchanski, Ph.D.
'---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow!
"The Sun will pass between the Earth and the Moon tonight for a total
Lunar eclipse..." -- WCBS Radio Newsbrief, Oct 27 2004, 12:01 pm EDT
