> Of course, rebind_main doesn't call BindImage or BindImageEx. It does > have a commented-out call to dll.rebind() -- but > LinkedObjectFile::rebind() doesn't call BindImage() or BindImageEx > either -- LinkedObjectFile::rebind() does all of the work itself. > > Looks like the factorization isn't quite complete...work in progress, right?
You've got the point :-) BindImage[Ex]() is only an imagehlp compatible wrapper, which I have written later. And it works, so I haven't recognized this. > > 1) some that go to stdout probably should be stderr, and vice versa. still open. I think debug message should go to cerr and normal printing should go to cout. > 2) some are guarded by 'if (debug)' and probably should be 'if (some > library call that returns the value of debug for this instance)' -- but > I didn't really check the lexical scope. These may be fine. For building and debugging a standalone rebase i think it is good. For the setup integration we can change this later. > 3) some aren't even guarded at all, and should be. I'm preparing a patch for this. > 4) Then there's that whole exceptions vs. print-an-error-message from > within the library deal. > still open Ralf
