[
https://issues.apache.org/jira/browse/CXF-1284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12557252#action_12557252
]
maomaode commented on CXF-1284:
-------------------------------
Hi Jeff,
I saw this in the patch, I personally think this is not a good practice, Can
you explain why we need do this?
I guess it is for two versions of JDK,
+ boolean boolA =
client.getEndpoint().getEndpointInfo().getName().equals(SOAP_PORT);
+ boolean boolB =
client.getEndpoint().getEndpointInfo().getName().equals(SOAP_PORT1);
+ assertTrue(boolA || boolB);
Can we do this:
if (isJDKVersion() > 6) {
assert...
} else {
assert...
}
> fix failed testcase on jdk1.6
> -----------------------------
>
> Key: CXF-1284
> URL: https://issues.apache.org/jira/browse/CXF-1284
> Project: CXF
> Issue Type: Sub-task
> Environment: cxf trunk, sun jdk 1.6.0_10ea, XP
> Reporter: Jeff Zhang
> Assignee: maomaode
> Fix For: 2.1
>
> Attachments: jdk6test.patch
>
>
> run test on jdk1.6.0_10ea
> some test failed:
> common/common
> ==============
> W3CDOMSteamReader:testReader
> tools
> wsdl/test
> =======
> Failed tests:
> testNonUniqueBody(org.apache.cxf.tools.wsdlto.jaxws.CodeGenBugTest)
> testCodeGen(org.apache.cxf.tools.wsdlto.jaxws.JAXWSContainerTest)
> testSuppressCodeGen(org.apache.cxf.tools.wsdlto.jaxws.JAXWSContainerTest)
> Tests in error:
> testWsdlNoService(org.apache.cxf.tools.wsdlto.jaxws.CodeGenBugTest)
> testNoServiceImport(org.apache.cxf.tools.wsdlto.jaxws.CodeGenBugTest)
> testNoServiceNOPortType(org.apache.cxf.tools.wsdlto.jaxws.CodeGenBugTest)
> Tests run: 106, Failures: 3, Errors: 3, Skipped: 0
> javato
> ====
> Failed tests:
>
> testDocLitWrappedWithWrapperClass(org.apache.cxf.tools.java2wsdl.processor.internal.jaxws.JaxwsServiceBuilderTest)
>
> testDocWrappedWithLocalName(org.apache.cxf.tools.java2wsdl.processor.internaljaxws.JaxwsServiceBuilderTest)
>
> testHolder(org.apache.cxf.tools.java2wsdl.processor.internal.jaxws.JaxwsServiceBuilderTest)
>
> testSoapHeader(org.apache.cxf.tools.java2wsdl.processor.internal.jaxws.JaxwsServiceBuilderTest)
>
> testRpcLitNoSEI(org.apache.cxf.tools.java2wsdl.processor.internal.jaxws.JaxwsServiceBuilderTest)
> testAegisBasic(org.apache.cxf.tools.java2ws.AegisTest)
>
> testGeneratedWithElementryClass(org.apache.cxf.tools.java2wsdl.processor.internal.jaxws.JaxwsServiceBuilderNoAnnoTest)
>
>
> testGeneratedWithDocWrappedClass(org.apache.cxf.tools.java2wsdl.processor.internal.jaxws.JaxwsServiceBuilderNoAnnoTest)
>
> testGeneratedWithRPCClass(org.apache.cxf.tools.java2wsdl.processor.internal.jaxws.JaxwsServiceBuilderNoAnnoTest)
>
> testGreeter(org.apache.cxf.tools.java2wsdl.processor.internal.jaxws.JaxwsServiceBuilderRPCTest)
> 10 failed
> rt
> frontend/jaxws
> ===========
> jaxws.ServiceImplTest:testNonSpecificGetPort
> javascript
> ========
> javascript.DocLitBareClientTest:callCompliantNoArgs
> systests
> =======
> jaxws.ClientServerTest:GetPortOneParam
> BasicConnect2
> ProviderXMLClientServerTest:testDomSourcePAYLOAD
> SpringServletTest:testGetWSDL
> servlet.ExternalServicesServletTest:testGetServiceList
> CXFServletTest
> Failed tests:
> testGetWSDL(org.apache.cxf.systest.servlet.CXFServletTest)
> testGetServiceList(org.apache.cxf.systest.servlet.CXFServletTest)
> testGetWSDLWithXMLBinding(org.apache.cxf.systest.servlet.CXFServletTest)
> provider.ProviderRPCClientServerTest:testSWA
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
