On 31/10/2009 12:21, Manuel M T Chakravarty wrote:
Out of curiosity, I just validated on Linux (on some flavour of 32-bit
Debian), too — it doesn't look much better:

Unexpected failures:
Base1(normal)
Compose(normal)
PList1(normal)
PList2(normal)
T1969(normal)
T3007(normal)
T3294(normal)
boxy(normal)
break008(ghci)
print033(ghci)
simpl017(normal)
tc211(normal)
tc214(normal)
tcfail165(normal)
user001(normal)

Manuel


Manuel M T Chakravarty:
Today, I am getting 17 failures in validate:

Unexpected failures:
2302(normal)
2816(ghci)
Base1(normal)
Compose(normal)
PList1(normal)
PList2(normal)
T1969(normal)
T3294(normal)
boxy(normal)
ffi005(normal)
ghci028(ghci)
print021(ghci)
print033(ghci)
simpl017(normal)
tc211(normal)
tc214(normal)
tcfail165(normal)

Some are space-leak tests that exceed the allowed allocation a little
and some of complaints that predicative types are deprecated. I didn't
check them all, but they surely are not all platform dependent and
should have been picked up by any validate run.

I am getting:

Unexpected failures:
   Base1(normal)
   Compose(normal)
   PList1(normal)
   PList2(normal)
   T1969(normal)
   boxy(normal)
   print033(ghci)
   simpl017(normal)
   tc211(normal)
   tc214(normal)
   tcfail165(normal)

The vast majority of which are of the form:

=====> Base1(normal)
cd ./boxy && '/64playpen/simonmar/validate/bindisttest/installed/bin/ghc' -fforce-recomp -dcore-lint -dcmm-lint -no-user-package-conf -dno-debug-output -c Base1.hs >Base1.comp.stderr 2>&1
Actual stderr output differs from expected:
--- /dev/null   2008-11-03 06:58:18.332439523 +0000
+++ ./boxy/Base1.comp.stderr.normalised 2009-11-03 12:22:26.000000000 +0000
@@ -0,0 +1,3 @@
+
+Base1.hs:1:15:
+ Warning: -XImpredicativeTypes is deprecated: Impredicative polymorphism will be simplified or removed in GHC 6.14


Simon, did you forget to push your testsuite?

(Also, the warning should probably say 6.14.1, rather than 6.14).

T1969 has also wobbled:

=====> T1969(normal)
cd ./space_leaks && '/64playpen/simonmar/validate/bindisttest/installed/bin/ghc' -fforce-recomp -dcore-lint -dcmm-lint -no-user-package-conf -dno-debug-output -c T1969.hs +RTS -V0 -tT1969.comp.stats --machine-readable -RTS >T1969.comp.stderr 2>&1
max_bytes_used 13332424 is more than maximum allowed 13000000
bytes allocated 516525896 is more than maximum allowed 480000000
*** unexpected failure for T1969(normal)

Can I remind people that T1969 is there for a good reason: when it wobbles, it may indicate a performance regression. We should keep the boundaries updated so that people don't just ignore it as a matter of course.

I realise it's difficult to keep it updated because it has to be done on multiple platforms. But at the very least if your patch makes it fail, you should update the values for *your* platform (after checking that you haven't really introduced a performance regression).

Cheers,
        Simon

_______________________________________________
Cvs-ghc mailing list
Cvs-ghc@haskell.org
http://www.haskell.org/mailman/listinfo/cvs-ghc

Reply via email to