On Mon, 15 Dec 2025 21:20:29 GMT, Justin Lu <[email protected]> wrote:

>> This PR addresses a performance degradation when constructing a new 
>> MessageFormat that contains a subformat with a pattern that is not a 
>> predefined style. This is due to internal logic which catches an IAE 
>> specifically for subformat patterns. Perf tests for choice and number are 
>> not grouped, since performance is directly tied to subformat creation.
>> 
>> M1 Mac - Perf (before):
>> 
>> 
>> MessageFormatterBench.testSubformatChoice  thrpt   15   865.430 ±  6.766  
>> ops/ms
>> MessageFormatterBench.testSubformatNumber  thrpt   15  1021.808 ± 11.413  
>> ops/ms
>> 
>> 
>> M1 Mac - Perf (after):
>> 
>> 
>> Benchmark                                   Mode  Cnt     Score    Error   
>> Units
>> MessageFormatterBench.testSubformatChoice  thrpt   15  1671.033 ± 55.012  
>> ops/ms
>> MessageFormatterBench.testSubformatNumber  thrpt   15  3275.727 ± 47.370  
>> ops/ms
>
> Justin Lu has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   spacing of increment

Marked as reviewed by liach (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/28806#pullrequestreview-3580310763

Reply via email to