> Hi all, > > The DockerTestUtils.RETAIN_IMAGE_AFTER_TEST variable which read the property > from "jdk.test.docker.retain.image" do not work for some of the docker tests, > such as jdk/internal/platform/docker/TestDockerCpuMetrics.java, only works > for some of the docker tests, such as > jdk/internal/platform/docker/TestPidsLimit.java. > > This PR read the DockerTestUtils.RETAIN_IMAGE_AFTER_TEST inside function > removeDockerImage instead of before all the fucntion removeDockerImage. This > will make all the docker tests receive the property > jdk.test.docker.retain.image. > > Change has been verified locally on linux-x64 by run the all touched tests.
SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'openjdk:master' into jbs8371503 - Remove extra ident - 8371503: RETAIN_IMAGE_AFTER_TEST do not work for some tests ------------- Changes: - all: https://git.openjdk.org/jdk/pull/28208/files - new: https://git.openjdk.org/jdk/pull/28208/files/5e39c8f3..0bfbe8ae Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=28208&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=28208&range=01-02 Stats: 301873 lines in 2852 files changed: 201864 ins; 58740 del; 41269 mod Patch: https://git.openjdk.org/jdk/pull/28208.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/28208/head:pull/28208 PR: https://git.openjdk.org/jdk/pull/28208
