On Tue, 9 Dec 2025 08:13:33 GMT, Eric Fang <[email protected]> wrote:
>> But then the loop can start from `idx + 1` instead of `idx`, right? > > What I really wanted to talk about was code consistency and maintainability. > There are many ways to handle this problem if we want to. I just think the > current code style might be more maintainable, since the masked version is > written this way too. The code looks more consistent. Consistency does not mean much if the test does not actually do its job adequately, though. Since the very reason this test does not catch this issue is that it is just a repetition of the thing it supposedly verifies, I think it is necessary to write the test in a different way. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28692#discussion_r2601571064
