On Mon, 8 Dec 2025 17:51:46 GMT, Justin Lu <[email protected]> wrote:

>> Naoto Sato has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Further wording refinement
>
> test/jdk/java/util/Locale/LocaleTest.java line 712:
> 
>> 710:         Locale indonesianNew = Locale.of("id");
>> 711: 
>> 712:         if (!hebrewOld.getLanguage().equals("he")) {
> 
> Since we are using JUnit, these assertions would be cleaner as `assertEquals`.

In this test file, there are other locations that use `fail`. Although it would 
be preferred to replace them with `assertEquals`, probably  better be cleaned 
up with a separate issue.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26419#discussion_r2599806334

Reply via email to