On Tue, 19 Aug 2025 21:50:33 GMT, Roger Riggs <[email protected]> wrote:
>> The teardown of a Process launched by `ProcessBuilder` includes the closing
>> of streams and ensuring the termination of the process is the responsibility
>> of the caller. The `Process.close()` method provides a clear and obvious way
>> to ensure all the streams are closed and the process terminated.
>>
>> The try-with-resources statement is frequently used to open streams and
>> ensure they are closed on exiting the block. By implementing
>> `AutoClosable.close()` the completeness of closing the streams and process
>> termination can be done by try-with-resources.
>>
>> The actions of the `close()` method are to close each stream and destroy the
>> process if it has not terminated.
>
> Roger Riggs has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Revisited handling of IOExceptions to throw instead of completely ignoring
> or logging.
src/java.base/share/classes/java/lang/Process.java line 146:
> 144: * @since 1.0
> 145: */
> 146: public abstract class Process implements AutoCloseable {
Since we added `throws IOException` to `close()`, have we considered
implementing `Closeable` instead?
src/java.base/share/classes/java/lang/Process.java line 651:
> 649: * @since 26
> 650: */
> 651: public void close() throws IOException {
Suggestion:
@Override
public void close() throws IOException {
test/jdk/java/lang/Process/ProcessCloseTest.java line 386:
> 384: break;
> 385: } catch (InterruptedException ie) {
> 386: // retry above
Are we sure about completely discarding the interrupt?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26649#discussion_r2287302548
PR Review Comment: https://git.openjdk.org/jdk/pull/26649#discussion_r2287295760
PR Review Comment: https://git.openjdk.org/jdk/pull/26649#discussion_r2287315234
