On Thu, 14 Aug 2025 20:39:10 GMT, Albert Mingkun Yang <[email protected]> wrote:
>> Guanqiang Han has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Update exePrintSignalDisposition.c >> >> a small fix >> - Update exePrintSignalDisposition.c >> >> Refactor act.sa_mask output > > The fix looks reasonable. However, the discrepancy btw and AIX and others > seems unnecessary complexity. I'd prefer having `ifdef` removed also. > > Looking at how these prints are used/tested, I believe `sa_mask` is not > really needed and it doesn't seem very useful also. Therefore, I'd suggest > removing it, just like what's done for AIX. My 2c. hi @albertnetymk , thanks for the feedback! I agree that removing it would be the simplest solution. Let’s get @MBaesken input as well, and if we reach an agreement, I’m happy to proceed with the simplest approach. ------------- PR Comment: https://git.openjdk.org/jdk/pull/26771#issuecomment-3190282210
