On Tue, 12 Aug 2025 01:01:08 GMT, Alexander Matveev <[email protected]>
wrote:
>> Alexey Semenyuk has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Blessed modifiers order
>> - Rework AddLShortcutTest.test() to verify the working directory in which
>> one of the additional launchers is started when invoked through a shortcut.
>
> test/jdk/tools/jpackage/share/AddLShortcutTest.java line 95:
>
>> 93: public class AddLShortcutTest {
>> 94:
>> 95: @Test(ifNotOS = OperatingSystem.MACOS)
>
> Do we really need both `(ifNotOS = OperatingSystem.MACOS)` and `(os.family !=
> "mac")`?
The one is for jtreg, and the other is for the jpackage test runner. The latter
makes sense when the test is executed outside of jtreg.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26707#discussion_r2268410054
