On Fri, 18 Jul 2025 19:58:30 GMT, Raffaello Giulietti <rgiulie...@openjdk.org>
wrote:
>> Align the behavior of `DecimalFormat` on `double`s with that of `Formatter`.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Removed temporary comment from tests.
Looks good to me. Some minor comments for the test follow.
test/jdk/java/text/Format/DecimalFormat/DoubleFormattingTest.java line 28:
> 26: * @bug 8362448
> 27: * @summary Verify DecimalFormat::format on doubles.
> 28: * @run junit/othervm DoubleFormattingTest
`othervm` can be removed
test/jdk/java/text/Format/DecimalFormat/DoubleFormattingTest.java line 45:
> 43: private static final boolean COMPAT =
> Boolean.getBoolean("jdk.compat.DecimalFormat");
> 44:
> 45: @Test
Using `@ParameterizedTest` would eliminate the duplication of code
-------------
PR Review: https://git.openjdk.org/jdk/pull/26364#pullrequestreview-3034782721
PR Review Comment: https://git.openjdk.org/jdk/pull/26364#discussion_r2216886702
PR Review Comment: https://git.openjdk.org/jdk/pull/26364#discussion_r2216886783
