On Thu, 3 Jul 2025 00:09:14 GMT, Ioi Lam <ik...@openjdk.org> wrote:
>> Also quick question: Should I use `_transitive_interfaces` or can I use
>> `_local_interfaces`?
>
> local_interfaces is fine, because the interfaces implemented by the super
> classes would have been checked when the super classes were loaded.
>
> BTW, the error message should include the name of both this class and the
> supertype:
>
>
> classfile_parse_error("AOTSafeClassInitlaizer annotation is required for
> supertype %s of %s", ...
>
>
> And the checks can be refactored in a separate function to avoid repetition.
>
>
> if (_super_klass != nullptr) {
> check_aot_safe_initializer(ik, _super_klass, CHECK);
> }
> int len = _local_interfaces->length();
> for (int i = 0; i < len; i++) {
> check_aot_safe_initializer(ik, _local_interfaces->at(i), CHECK);
> }
I don't want to introduce a new declaration in the header for this function -
to shrink the size, I think I can use `guarantee_property` instead.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25922#discussion_r2182930135
