On Wed, 2 Jul 2025 11:00:44 GMT, Manuel Hässig <mhaes...@openjdk.org> wrote:
> When a check in `CommandLineOptionTest` fails, the `AssertionError` message > contains the expected value, but not the observed value. To reduce the amount > of digging in the logs we have to do when analyzing a failure, this PR adds > the observed value to the error messages. So instead of > > > java.lang.AssertionError: Option 'CICompilerCount' is expected to have '12' > value > > > a mismatch in the `CICompilerCount` will now print > > > java.lang.AssertionError: Option 'CICompilerCount' is expected to have '12' > value, but is 'CICompilerCount = 6'. > > > Testing: > - [ ] Github Actions > - [ ] tier1 through tier3 plus Oracle internal testing This looks reasonable to me. Thanks for addressing this so promptly! There was a typo in the JBS issue title so you will need to adjust here. ------------- Marked as reviewed by dholmes (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/26092#pullrequestreview-2978917364
