On Tue, 1 Jul 2025 14:32:41 GMT, ExE Boss <d...@openjdk.org> wrote: >> David Beaumont has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Small feedback related tweaks. > > src/java.base/share/classes/jdk/internal/jimage/ImageReader.java line 207: > >> 205: this.nodes = new HashMap<>(); >> 206: // TODO (review note): These should exist under all >> circumstances, but there's >> 207: // probably a more robust way of getting it these offsets. > > Suggestion: > > // probably a more robust way of getting these offsets.
Done. > src/java.base/share/classes/jdk/internal/jimage/ImageReader.java line 211: > >> 209: this.packagesStringOffset = >> findLocation("/packages/java.lang").getModuleOffset(); >> 210: >> 211: // Node creation is very lazy, se can just make the >> top-level directories > > Typo: > Suggestion: > > // Node creation is very lazy, so can just make the top-level > directories Done. > src/java.base/share/classes/jdk/internal/jimage/ImageReader.java line 544: > >> 542: >> 543: // A node is completed when all its direct children have been >> built. As >> 544: // such, non-directory nodes are always complete. > > I think this might flow better: > Suggestion: > > // A node is completed when all its direct children have been built. > // As such, non-directory nodes are always complete. Done. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/26054#discussion_r2179459970 PR Review Comment: https://git.openjdk.org/jdk/pull/26054#discussion_r2179460025 PR Review Comment: https://git.openjdk.org/jdk/pull/26054#discussion_r2179459756