On Tue, 1 Jul 2025 00:41:03 GMT, Xueming Shen <sher...@openjdk.org> wrote:
> While I understand the motivation behind the PR, it's a bit challenging, as a > reviewer :-) to review a change that is essentially to 'break' the > abstraction layer by surfacing a lower-level implementation to the top API > solely for performance gains. Maybe it's easier to add an impl note to > suggest "it's no longer always a good idea to put a buffered writer on top of > an osw", for example. > > It might be better to separate the 'backdoor UTF-8 path' optimization and the > 'skip BufferedWriter' change as a first step to start the discussion? After the introduction of JEP 254 Compact Strings, many java.io-related codes need to be optimized for Compact Strings. If we plan to remove the option COMPACT_STRING = off, we should do these optimizations before that. ------------- PR Comment: https://git.openjdk.org/jdk/pull/26022#issuecomment-3021532618
