On Mon, 30 Jun 2025 16:18:00 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
> Can I please get a review of this test-only change which addresses the issue > noted in https://bugs.openjdk.org/browse/JDK-8359337? > > On macOS, the JDK by default (without any explicit system properties) picks > up the proxy settings configured on the host. These proxy settings then get > used by the JVM wide `DefaultProxySelector`. That can then result in some > tests, like the ones listed in that issue, to fail. > > The commit in this PR updates these tests to disable the proxy when running > these tests. I've verified that after these changes, these tests now pass on > the host where these tests were failing previously. Additionally I've run > tier2 to make sure nothing else is impacted due to this change. Thanks Jaikiran. nit: may add the bug id (8359337) to the @bug tag. ------------- Marked as reviewed by joehw (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/26052#pullrequestreview-2971950042
