On Fri, 27 Jun 2025 14:55:10 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 525 commits: >> >> - merge latest changes from master branch >> - http3: run H3StreamLimitReachedTest.java with >> -Djdk.httpclient.http3.maxStreamLimitTimeout=0 too >> - retry the ResetControlStream test as needed >> - http3: fix pending connection and reconnection on stream limit reached >> logic >> - http3: pending acknowledgement should be registered before actually >> sending the packet >> - http3: fix race with ping requests in PacketSpaceManager.java causing >> intermittent failures in H3ErrorHandlingTest.java >> - http3: improve exceptions in Http3ServerExchange.java >> - http3: fix exception handling in CancelRequestTest.java >> - http3: review feedback - revert HPACK.java >> - Implement X509TrustManagerImpl#checkClientTrusted for QUIC >> - ... and 515 more: https://git.openjdk.org/jdk/compare/5a1301df...0229c215 > > src/java.net.http/share/classes/jdk/internal/net/http/AltServicesRegistry.java > line 186: > >> 184: return new Origin(scheme, originHost, addr.getPort()); >> 185: } >> 186: } > > I don't think it's a good idea to rely on > `InetSocketAddress::getHostString()` as this can change depending on how the > `InetSocketAddress` was constructed and whether `getHost()` has been called. > I believe it would be more reliable to add a new `URI origin` parameter to > the `HttpConnection` constructor. We could build that origin from the request > URI for which the connection was created. Probably `origin` should be `null` > for `PlainProxyConnection`. I've created https://bugs.openjdk.org/browse/JDK-8361060 to track this. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24751#discussion_r2174603879
