On Sat, 28 Jun 2025 07:01:29 GMT, Alan Bateman <al...@openjdk.org> wrote:

>> Jaikiran Pai has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Andy's review suggestions
>
> src/java.base/share/classes/java/util/Properties.java line 1219:
> 
>> 1217:      * @implNote If any property's value is greater than 40 characters 
>> then
>> 1218:      * this method writes only the first 37 characters of that value
>> 1219:      * followed by 3 dot characters.
> 
> I don't think the note needs to that specific. I think it need only say that 
> the implementation truncates the output for very long property values.

Hello Alan, I think not noting the character count which determines the 
truncation would lead to questions about what "very long property values" are. 
However, this is a method which is specified to be for debug purposes only and 
I see that there's a suggestion to deprecate these methods. So I have gone 
ahead and updated this text to follow your suggestion. I'll respond to the 
deprecation proposal separately in this PR.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26018#discussion_r2174286506

Reply via email to