On Fri, 27 Jun 2025 18:44:55 GMT, Roger Riggs <rri...@openjdk.org> wrote:
>> Brian Burkhalter has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - 8358533: Use a boolean instead of fragPos != -1 >> - 8358533: Immediately skip LF right after CR > > src/java.base/share/classes/java/io/Reader.java line 494: > >> 492: skipLF = isCR; >> 493: } else { // no line terminator >> 494: int len = term - pos; > > I think term == limit here and it seems a bit of a mismatch when the comment > says there is no terminator. Yes, `term == limit`. The "no line terminator" means none was encountered before the buffer's end was reached. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25863#discussion_r2172676725